Skip to content

fix docker elasticsearch and oap host#2574

Merged
wu-sheng merged 3 commits into
apache:masterfrom
neatlife:hotfix/fix-docker-elasticsearch-and-oap-host
May 7, 2019
Merged

fix docker elasticsearch and oap host#2574
wu-sheng merged 3 commits into
apache:masterfrom
neatlife:hotfix/fix-docker-elasticsearch-and-oap-host

Conversation

@neatlife
Copy link
Copy Markdown
Contributor

@neatlife neatlife commented May 4, 2019 •
edited
Loading

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • Related issues
    find by me

Bug fix

  • use docker container name replace localhost
  • replace collector.ribbon.listOfServers with collectorListOfServers because environment variable name not support .(dot)

@wu-sheng wu-sheng requested a review from hanahmily May 4, 2019 05:14
@wu-sheng wu-sheng added the bug Something isn't working and you are sure it's a bug! label May 4, 2019
@wu-sheng wu-sheng added this to the 6.2.0 milestone May 4, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented May 4, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 16.416% when pulling 2413170 on neatlife:hotfix/fix-docker-elasticsearch-and-oap-host into ea347b8 on apache:master.

hanahmily
hanahmily approved these changes May 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@hanahmily hanahmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wu-sheng wu-sheng added the docker Docker build scripts or images related label May 7, 2019
@wu-sheng wu-sheng merged commit 4e71085 into apache:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanahmily hanahmily hanahmily approved these changes

Assignees

No one assigned

Labels

bug Something isn't working and you are sure it's a bug! docker Docker build scripts or images related

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@neatlife @coveralls @hanahmily @wu-sheng