fix bug about webflux broken trace #5335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5335 +/- ##
============================================
+ Coverage 53.13% 53.41% +0.27%
- Complexity 3204 3211 +7
============================================
Files 828 828
Lines 20830 20768 -62
Branches 2019 2006 -13
============================================
+ Hits 11069 11093 +24
+ Misses 8856 8768 -88
- Partials 905 907 +2
Continue to review full report at Codecov.
|
wu-sheng
reviewed
Aug 17, 2020
| @@ -79,6 +78,7 @@ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allA | |||
| return ((Mono) ret).doFinally(s -> { | |||
| AbstractSpan span = (AbstractSpan) exchange.getAttributes().get("SKYWALING_SPAN"); | |||
| if (span != null) { | |||
| ContextManager.stopSpan(span); | |||
There was a problem hiding this comment.
I double this is a fix. This should be a part of another thread.
|
@ascrutae I will wait for your confirmation. |
|
@ascrutae I close this for now. Wait for your fix. |
wu-sheng
added
wontfix
|
Is this webflux use @requestbody with problem solved? i have same question, Can you give me some ideas? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
the trace of webflux application which use @RequestBody is broken #5184
the trace of webflux application which use @requestbody is broken
skywalking has some problem with webflux #4957
skywalking has some problem with webflux
I put the stopSpan operation in DispatcherHandlerHandleMethodInterceptor from beforeMethod to afterMethod
New feature or improvement