Fix entity naming mechanism failure in MAL#7790
Merged
Merged
Conversation
kezhenxu94
requested changes
Sep 24, 2021
Member
kezhenxu94
left a comment
There was a problem hiding this comment.
This fix is fragile, MeterEntity exposes many means to construct its instances, this patch only covers the static methods newService, newServiceInstance, newEndpoint, newServiceRelation, future developers who use the uncovered cases to construct the entity might cause the bug again.
The other uncovered cases:
MeterEntity.builder().serviceName("").instanceName("")..., if it's designed to only use thenewXxxxmethods to constructMeterEntity, we should update the@Builderannotation to@Builder(toBuilder = true, access = AccessLevel.PRIVATE)meterEntity.toBuilder()returns another builder, which is the same case with (1.), we'd better also removetoBuilder = truein@Buildernewconstructor (although it's package-private), we'd better also make itprivate.
Member
Author
|
@kezhenxu94 I removed |
kezhenxu94
approved these changes
Sep 24, 2021
wankai123
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.Fix entity(service/instance/endpoint) names in the MAL system(prometheus, native meter, open census, envoy metric service) are not controlled by core's naming-control mechanism.