SLING-5618 - Make the ResourceChangeCommandFactory independent from Eclipse

- Introduce abstractions in the API module which support
  working with the ResourceChangeCommandFactory outside of Eclipse.
- Implement needed abstractions in the eclipse-core module and stop using
  the ResourceChangeCommandFactory internally
- The ResourceChangeCommandFactory is now left only as a deprecated stub
  until the tests are ported to use the DefaultCommandFactoryImpl.

Author: rombert

eclipse/eclipse-core/META-INF/MANIFEST.MF

@@ -24,6 +24,7 @@ Import-Package: org.apache.commons.httpclient;version="3.1.0",
  org.apache.sling.ide.log,
  org.apache.sling.ide.osgi,
  org.apache.sling.ide.serialization,
+ org.apache.sling.ide.sync.content,
  org.apache.sling.ide.transport,
  org.apache.sling.ide.util,
  org.eclipse.core.commands,

eclipse/eclipse-core/src/org/apache/sling/ide/eclipse/core/EclipseResources.java

@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.ide.eclipse.core;
+
+import java.util.Set;
+
+import org.apache.sling.ide.eclipse.core.internal.Activator;
+import org.apache.sling.ide.eclipse.core.internal.sync.content.EclipseWorkspaceDirectory;
+import org.apache.sling.ide.eclipse.core.internal.sync.content.EclipseWorkspaceFile;
+import org.apache.sling.ide.eclipse.core.internal.sync.content.EclipseWorkspaceProject;
+import org.apache.sling.ide.sync.content.WorkspaceResource;
+import org.eclipse.core.resources.IFile;
+import org.eclipse.core.resources.IFolder;
+import org.eclipse.core.resources.IProject;
+import org.eclipse.core.resources.IResource;
+
+public abstract class EclipseResources {
+
+    public static WorkspaceResource create(IResource resource) {
+        
+        Set<String> ignoredFileNames = Activator.getDefault().getPreferences().getIgnoredFileNamesForSync();
+        
+        switch ( resource.getType() ) {
+        case IResource.FILE:
+            return new EclipseWorkspaceFile((IFile) resource, ignoredFileNames);
+        case IResource.FOLDER:
+            return new EclipseWorkspaceDirectory((IFolder) resource, ignoredFileNames);
+        case IResource.PROJECT:
+            return new EclipseWorkspaceProject((IProject) resource, ignoredFileNames);
+            default:
+                throw new IllegalArgumentException("Unable to create a local resource for Eclipse IResource.getType() = " + resource.getType() );
+        }
+    }
+    
+    private EclipseResources() {
+        
+    }
+}

eclipse/eclipse-core/src/org/apache/sling/ide/eclipse/core/ResourceUtil.java

@@ -17,6 +17,7 @@
 package org.apache.sling.ide.eclipse.core;
 
 import org.apache.sling.ide.eclipse.core.internal.Activator;
+import org.apache.sling.ide.sync.content.SyncCommandFactory;
 import org.eclipse.core.resources.IResource;
 import org.eclipse.core.runtime.QualifiedName;
 
@@ -36,7 +37,7 @@ public abstract class ResourceUtil {
      * </p>
      */
     public static final QualifiedName QN_IMPORT_MODIFICATION_TIMESTAMP = new QualifiedName(Activator.PLUGIN_ID,
-            "importModificationTimestamp");
+            SyncCommandFactory.PN_IMPORT_MODIFICATION_TIMESTAMP);
 
     private ResourceUtil() {
 

eclipse/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/Activator.java

@@ -28,6 +28,7 @@
 import org.apache.sling.ide.log.Logger;
 import org.apache.sling.ide.osgi.OsgiClientFactory;
 import org.apache.sling.ide.serialization.SerializationManager;
+import org.apache.sling.ide.sync.content.SyncCommandFactory;
 import org.apache.sling.ide.transport.BatcherFactory;
 import org.apache.sling.ide.transport.CommandExecutionProperties;
 import org.apache.sling.ide.transport.RepositoryFactory;
@@ -63,6 +64,7 @@ public class Activator extends Plugin {
     private ServiceTracker<Logger, Logger> tracer;
     private ServiceTracker<BatcherFactory, BatcherFactory> batcherFactoryLocator;
     private ServiceTracker<SourceReferenceResolver, Object> sourceReferenceLocator;
+    private ServiceTracker<SyncCommandFactory, SyncCommandFactory> commandFactory;
 
     private ServiceRegistration<Logger> tracerRegistration;
 
@@ -107,6 +109,9 @@ public void start(BundleContext context) throws Exception {
 
         sourceReferenceLocator = new ServiceTracker<>(context, SourceReferenceResolver.class, null);
         sourceReferenceLocator.open();
+        
+        commandFactory = new ServiceTracker<>(context, SyncCommandFactory.class, null);
+        commandFactory.open();
 	}
 
 	/*
@@ -128,6 +133,7 @@ public void stop(BundleContext context) throws Exception {
         tracer.close();
         batcherFactoryLocator.close();
         sourceReferenceLocator.close();
+        commandFactory.close();
 
         plugin = null;
 		super.stop(context);
@@ -172,6 +178,10 @@ public BatcherFactory getBatcherFactory() {
         return (BatcherFactory) ServiceUtil.getNotNull(batcherFactoryLocator);
     }
 
+    public SyncCommandFactory getCommandFactory() {
+        return ServiceUtil.getNotNull(commandFactory);
+    }
+    
     /**
      * @deprecated This should not be used directly to communicate with the client . There is no direct replacement
      */