SLING-10447 Improve the querys that are used to load vanity paths, by specifying path restrictions #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 2, 2021 18:43
… specifying path restrictions
…torage # Conflicts: # src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java # src/test/java/org/apache/sling/resourceresolver/impl/mapping/InMemoryResourceProvider.java
…s now superseded by the alias, vanity & mapping root settings
|
Thanks for the PR @henrykuijpers ! I'll not merge it immediately as @kwin has some concerns on whether this is the right thing to do. If we end up going this way, we will need the branch to be rebased as it has conflicts. |
jsedding
requested changes
Jun 3, 2021
src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java
Show resolved
Hide resolved
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java
Outdated
Show resolved
Hide resolved
…te sets, make /jcr:system exclude default in ResourceResolverFactoryActivator, make query building code easier to read/understand
|
Just did a commit with some fixes, @jsedding . :) Can you have another look? |
cziegeler
reviewed
Jun 10, 2021
src/main/java/org/apache/sling/resourceresolver/impl/CommonResourceResolverFactoryImpl.java
Show resolved
Hide resolved
bdelacretaz
reviewed
Jun 11, 2021
src/test/java/org/apache/sling/resourceresolver/impl/mapping/MapEntriesTest.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
cziegeler
reviewed
Aug 18, 2021
| @@ -707,7 +748,7 @@ public void onChange(final List<ResourceChange> changes) { | |||
| log.debug("onChange, type={}, path={}", rc.getType(), path); | |||
|
|
|||
| // don't care for system area | |||
| if (path.startsWith(JCR_SYSTEM_PREFIX)) { | |||
| if (path.startsWith(JCR_SYSTEM_PATH + '/')) { | |||
There was a problem hiding this comment.
while this is not a big deal, why did you change this from a constant to an expression that is executed each time?
There was a problem hiding this comment.
That is an oversight: I think I inlined a few values, I'll change it back to a constant.
|
Kudos, SonarCloud Quality Gate passed! |
|
This PR can be closed, right? (see https://issues.apache.org/jira/browse/SLING-10447) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.