New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-7512 Order features based on their dependencies. #6

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
2 participants
@bosschaert
Contributor

bosschaert commented Feb 23, 2018

Very initial implementation of feature ordering which contains the refactoring of Requirements and Capabilities to use the OSGi ones.

I'm a little unsure of the names of the classes that are currently called OSGiRequirement and OSGiCapability and would be open to better names. Just calling them Requirement/Capability is awkward as the OSGi interfaces they implement already have these names.

SLING-7512 Order features based on their dependencies.
Very initial implementation which contains the refactoring of
Requirements and Capabilities to use the OSGi ones.

@cziegeler cziegeler merged commit ff7caaf into apache:master Feb 23, 2018

@cziegeler

This comment has been minimized.

Show comment
Hide comment
@cziegeler

cziegeler Feb 23, 2018

Contributor

Thanks for the PR, David, I think the names are ok for now and it definitely makes sense to implement the OSGi interfaces as this makes things easier for the resolver

Contributor

cziegeler commented Feb 23, 2018

Thanks for the PR, David, I think the names are ok for now and it definitely makes sense to implement the OSGi interfaces as this makes things easier for the resolver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment