From 473ccae4827c9cd49af63175e43e8844b41329d5 Mon Sep 17 00:00:00 2001 From: Jason Gerlowski Date: Thu, 13 Mar 2025 15:45:39 -0400 Subject: [PATCH] Prevent RAW_GINKGO unset error in e2e tests Not all environments set particular `RAW_GINKGO` args, causing `make e2e-tests` to fail with an "unset variable" related error. This commit tweaks our `manage_e2e_tests.sh` script to guard against this case. --- tests/scripts/manage_e2e_tests.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/scripts/manage_e2e_tests.sh b/tests/scripts/manage_e2e_tests.sh index c42b92fb..9af0c5bd 100755 --- a/tests/scripts/manage_e2e_tests.sh +++ b/tests/scripts/manage_e2e_tests.sh @@ -130,7 +130,9 @@ function run_tests() { GINKGO_PARAMS+=("${param}" "${!envName}") fi done - GINKGO_PARAMS+=("${RAW_GINKGO[@]}") + if [[ -n "${RAW_GINKGO:-}" ]]; then + GINKGO_PARAMS+=("${RAW_GINKGO[@]}") + fi GINKGO_EDITOR_INTEGRATION=true ginkgo --randomize-all "${GINKGO_PARAMS[@]}" "${REPO_DIR}"/tests/e2e/...