Skip to content

Commit

Permalink
SOLR-16808: Don't publish envVars via the Metrics API
Browse files Browse the repository at this point in the history
  • Loading branch information
HoustonPutman committed May 19, 2023
1 parent 0a6a114 commit 35fc4bd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
2 changes: 2 additions & 0 deletions solr/CHANGES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ Bug Fixes

* SOLR-16801: Reset the thread's contextClassloader after loading the CoreContainer (Thomas Wöckinger, Houston Putman)

* SOLR-16808: Stop publishing environment variables via the Metrics API (Houston Putman)

Dependency Upgrades
---------------------
* PR#1494: Upgrade forbiddenapis to 3.5 (Uwe Schindler)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -468,18 +468,6 @@ private void setupJvmMetrics(CoreContainer coresInit, MetricsConfig config) {
ResolutionStrategy.IGNORE,
"properties",
"system");
MetricsMap sysenv =
new MetricsMap(
map ->
System.getenv()
.forEach(
(k, v) -> {
if (!hiddenSysProps.contains(k)) {
map.putNoEx(String.valueOf(k), v);
}
}));
metricManager.registerGauge(
null, registryName, sysenv, metricTag, ResolutionStrategy.IGNORE, "env", "system");
} catch (Exception e) {
log.warn("Error registering JVM metrics", e);
}
Expand Down

0 comments on commit 35fc4bd

Please sign in to comment.