Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Sep 30, 2024

Why are the changes needed?

This PR aims to make o.a.s.k8s.operator.utils.Utils argument naming consistent.

Does this PR introduce any user-facing change?

Utils has a mixed style for SparkApplication and SparkCluster argument. We had better be consistent.

  • SparkApplication argument:

public static Map<String, String> sparkAppResourceLabels(final SparkApplication app) {

public static Map<String, String> driverLabels(final SparkApplication sparkApplication) {

  • SparkCluster argument:

public static Map<String, String> sparkClusterResourceLabels(final SparkCluster master) {

public static Map<String, String> clusterLabels(final SparkCluster sparkCluster) {

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya . Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-49832 branch September 30, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants