Skip to content

[SPARK-49832] Make o.a.s.k8s.operator.utils.Utils argument naming consistent #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-49832] Make o.a.s.k8s.operator.utils.Utils argument naming consistent #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions spark-operator/src/main/java/org/apache/spark/k8s/operator/utils/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,26 +96,26 @@ public static Map<String, String> sparkAppResourceLabels(final String appName) {
return labels;
}

public static Map<String, String> driverLabels(final SparkApplication sparkApplication) {
Map<String, String> labels = sparkAppResourceLabels(sparkApplication);
public static Map<String, String> driverLabels(final SparkApplication app) {
Map<String, String> labels = sparkAppResourceLabels(app);
labels.put(Constants.LABEL_SPARK_ROLE_NAME, LABEL_SPARK_ROLE_DRIVER_VALUE);
return labels;
}

public static Map<String, String> executorLabels(final SparkApplication sparkApplication) {
Map<String, String> labels = sparkAppResourceLabels(sparkApplication);
public static Map<String, String> executorLabels(final SparkApplication app) {
Map<String, String> labels = sparkAppResourceLabels(app);
labels.put(Constants.LABEL_SPARK_ROLE_NAME, LABEL_SPARK_ROLE_EXECUTOR_VALUE);
return labels;
}

public static Map<String, String> sparkClusterResourceLabels(final SparkCluster master) {
public static Map<String, String> sparkClusterResourceLabels(final SparkCluster cluster) {
Map<String, String> labels = commonManagedResourceLabels();
labels.put(Constants.LABEL_SPARK_CLUSTER_NAME, master.getMetadata().getName());
labels.put(Constants.LABEL_SPARK_CLUSTER_NAME, cluster.getMetadata().getName());
return labels;
}

public static Map<String, String> clusterLabels(final SparkCluster sparkCluster) {
Map<String, String> labels = sparkClusterResourceLabels(sparkCluster);
public static Map<String, String> clusterLabels(final SparkCluster cluster) {
Map<String, String> labels = sparkClusterResourceLabels(cluster);
labels.put(Constants.LABEL_SPARK_ROLE_NAME, LABEL_SPARK_ROLE_CLUSTER_VALUE);
return labels;
}
Expand Down