[SPARK-54010] Support applicationTolerations.restartConfig.restartCounterResetMillis
#405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request? This PR adds support for automatic restart counter reset based on application attempt duration. The feature introduces a new `restartCounterResetMillis` field in RestartConfig that allows the restart counter to be reset if an application runs successfully for a specified duration before terminating. Also added unit test and enhanced existing test `assertGeneratedCRDMatchesHelmChart` to give diff fore readability. ### Why are the changes needed? With this feature, users can distinguish between persistent failures (quick consecutive crashes) and applications that run for long periods between failures. ### Does this PR introduce _any_ user-facing change? A new optional configuration field restartCounterResetMillis added to the RestartConfig spec. ### How was this patch tested? Added unit test that validates restart counter works as expected. ### Was this patch authored or co-authored using generative AI tooling? No
jiangzho
force-pushed
the
restart_counter
branch
from
3d041b3 to
5df833c
Compare
Contributor
Author
|
cc @peter-toth can you please help to review this ? |
dongjoon-hyun
changed the title
applicationTolerations.restartConfig.restartCounterResetMillis
Contributor
|
Sorry, for the delay @jiangzho, I can review this PR Thursday or Friday. |
peter-toth
approved these changes
Oct 29, 2025
Contributor
peter-toth
left a comment
peter-toth
left a comment
There was a problem hiding this comment.
Looks good to me, I have just minor comments.
spark-operator-api/src/main/java/org/apache/spark/k8s/operator/status/ApplicationStatus.java
Show resolved
Hide resolved
jiangzho
force-pushed
the
restart_counter
branch
from
d8594da to
a4e4a6d
Compare
Contributor
|
@dongjoon-hyun , https://issues.apache.org/jira/browse/SPARK-54010 is under the 0.7.0 unbrella. Would you like us to wait with merging this or do you think we can move it to 0.6.0? |
Member
|
Feel free to move, @peter-toth . |
Contributor
|
Thank you @jiangzho for the fix! Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds support for automatic restart counter reset based on application attempt duration. The feature introduces a new
restartCounterResetMillisfield in RestartConfig that allows the restart counter to be reset if an application runs successfully for a specified duration before terminating.Also added unit test.
Why are the changes needed?
With this feature, users can distinguish between persistent failures (quick consecutive crashes) and applications that run for long periods between failures.
Does this PR introduce any user-facing change?
A new optional configuration field restartCounterResetMillis added to the RestartConfig spec.
How was this patch tested?
Added unit test that validates restart counter works as expected.
Was this patch authored or co-authored using generative AI tooling?
No