From 7b244ff29d6cc4e19bdedc10ed30dda4ef3d26b7 Mon Sep 17 00:00:00 2001
From: Lianhui Wang <lianhuiwang09@gmail.com>
Date: Tue, 1 Dec 2015 22:59:58 +0800
Subject: [PATCH] address CodingCat's comments

---
 .../org/apache/spark/ui/exec/ExecutorsPage.scala     | 12 ++++++------
 docs/configuration.md                                |  7 +++++++
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala b/core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
index c9d5a6aee501c..460c932db42bd 100644
--- a/core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
@@ -69,7 +69,7 @@ private[ui] class ExecutorsPage(
   }
 
   private def listingExecTable(storageStatusList: Seq[StorageStatus], isActive: Boolean)
-      : Seq[Node] = {
+    : Seq[Node] = {
     val maxMem = storageStatusList.map(_.maxMem).sum
     val memUsed = storageStatusList.map(_.memUsed).sum
     val diskUsed = storageStatusList.map(_.diskUsed).sum
@@ -77,7 +77,7 @@ private[ui] class ExecutorsPage(
       ExecutorsPage.getExecInfo(listener, statusId, isActive)
     val execInfoSorted = execInfo.sortBy(_.id)
     val logsExist = execInfo.filter(_.executorLogs.nonEmpty).nonEmpty
-    val isShowThreadDump = threadDumpEnabled && isActive
+    val shouldShowThreadDump = threadDumpEnabled && isActive
 
     // scalastyle:off
     <div class="row-fluid">
@@ -115,10 +115,10 @@ private[ui] class ExecutorsPage(
             </span>
             </th>
             {if (logsExist) <th class="sorttable_nosort">Logs</th> else Seq.empty}
-            {if (isShowThreadDump) <th class="sorttable_nosort">Thread Dump</th> else Seq.empty}
+            {if (shouldShowThreadDump) <th class="sorttable_nosort">Thread Dump</th> else Seq.empty}
           </thead>
           <tbody>
-            {execInfoSorted.map(execRow(_, logsExist, isShowThreadDump))}
+            {execInfoSorted.map(execRow(_, logsExist, shouldShowThreadDump))}
           </tbody>
         </table>
       </div>
@@ -127,8 +127,8 @@ private[ui] class ExecutorsPage(
   }
 
   /** Render an HTML row representing an executor */
-  private def execRow(info: ExecutorSummary, logsExist: Boolean, isShowThreadDump: Boolean)
-      : Seq[Node] = {
+  private def execRow(info: ExecutorSummary, logsExist: Boolean, shouldShowThreadDump: Boolean)
+    : Seq[Node] = {
     val maximumMemory = info.maxMemory
     val memoryUsed = info.memoryUsed
     val diskUsed = info.diskUsed
diff --git a/docs/configuration.md b/docs/configuration.md
index 741d6b2b37a87..00b9a52e058fa 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -565,6 +565,13 @@ Apart from these, the following properties are also available, and may be useful
     How many finished batches the Spark UI and status APIs remember before garbage collecting.
   </td>
 </tr>
+<tr>
+  <td><code>spark.ui.retainedDeadExecutors</code></td>
+  <td>100</td>
+  <td>
+    How many dead executors the Spark UI and status APIs remember before garbage collecting.
+  </td>
+</tr>
 </table>
 
 #### Compression and Serialization