Skip to content

Commit

Permalink
[SPARK-28775][CORE][TESTS] Skip date 8633 in Kwajalein due to changes…
Browse files Browse the repository at this point in the history
… in tzdata2018i that only some JDK 8s use

### What changes were proposed in this pull request?

Some newer JDKs use the tzdata2018i database, which changes how certain (obscure) historical dates and timezones are handled. As previously, we can pretty much safely ignore these in tests, as the value may vary by JDK.

### Why are the changes needed?

Test otherwise fails using, for example, JDK 1.8.0_222. https://bugs.openjdk.java.net/browse/JDK-8215982 has a full list of JDKs which has this.

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

Existing tests

Closes #25504 from srowen/SPARK-28775.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 3b4e345)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
srowen authored and dongjoon-hyun committed Aug 20, 2019
1 parent d97d0ac commit 8b1067e
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -657,12 +657,12 @@ class DateTimeUtilsSuite extends SparkFunSuite {

// There are some days are skipped entirely in some timezone, skip them here.
val skipped_days = Map[String, Set[Int]](
"Kwajalein" -> Set(8632),
"Kwajalein" -> Set(8632, 8633),
"Pacific/Apia" -> Set(15338),
"Pacific/Enderbury" -> Set(9130, 9131),
"Pacific/Fakaofo" -> Set(15338),
"Pacific/Kiritimati" -> Set(9130, 9131),
"Pacific/Kwajalein" -> Set(8632),
"Pacific/Kwajalein" -> Set(8632, 8633),
"MIT" -> Set(15338))
for (tz <- DateTimeTestUtils.ALL_TIMEZONES) {
val skipped = skipped_days.getOrElse(tz.getID, Set.empty)
Expand Down

0 comments on commit 8b1067e

Please sign in to comment.