From 69b30dd727c1ad50b4eea8e025ab182f0a34c58e Mon Sep 17 00:00:00 2001 From: Jeff Zhang Date: Fri, 18 Dec 2015 11:03:41 +0800 Subject: [PATCH 1/2] [CORE][TESTS] minor fix of JavaSerializerSuite --- .../org/apache/spark/serializer/JavaSerializerSuite.scala | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/core/src/test/scala/org/apache/spark/serializer/JavaSerializerSuite.scala b/core/src/test/scala/org/apache/spark/serializer/JavaSerializerSuite.scala index 20f45670bc2b..fcb700958cc9 100644 --- a/core/src/test/scala/org/apache/spark/serializer/JavaSerializerSuite.scala +++ b/core/src/test/scala/org/apache/spark/serializer/JavaSerializerSuite.scala @@ -23,13 +23,17 @@ class JavaSerializerSuite extends SparkFunSuite { test("JavaSerializer instances are serializable") { val serializer = new JavaSerializer(new SparkConf()) val instance = serializer.newInstance() - instance.deserialize[JavaSerializer](instance.serialize(serializer)) + val obj = instance.deserialize[JavaSerializer](instance.serialize(serializer)) + // enforce class cast + obj.getClass } test("Deserialize object containing a primitive Class as attribute") { val serializer = new JavaSerializer(new SparkConf()) val instance = serializer.newInstance() - instance.deserialize[JavaSerializer](instance.serialize(new ContainsPrimitiveClass())) + val obj = instance.deserialize[ContainsPrimitiveClass](instance.serialize(new ContainsPrimitiveClass())) + // enforce class cast + obj.getClass } } From 91094745cd8e72190e23cd708897f09aeef2f23f Mon Sep 17 00:00:00 2001 From: Jeff Zhang Date: Fri, 18 Dec 2015 11:48:47 +0800 Subject: [PATCH 2/2] fix code style --- .../org/apache/spark/serializer/JavaSerializerSuite.scala | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/src/test/scala/org/apache/spark/serializer/JavaSerializerSuite.scala b/core/src/test/scala/org/apache/spark/serializer/JavaSerializerSuite.scala index fcb700958cc9..6a6ea42797fb 100644 --- a/core/src/test/scala/org/apache/spark/serializer/JavaSerializerSuite.scala +++ b/core/src/test/scala/org/apache/spark/serializer/JavaSerializerSuite.scala @@ -31,7 +31,8 @@ class JavaSerializerSuite extends SparkFunSuite { test("Deserialize object containing a primitive Class as attribute") { val serializer = new JavaSerializer(new SparkConf()) val instance = serializer.newInstance() - val obj = instance.deserialize[ContainsPrimitiveClass](instance.serialize(new ContainsPrimitiveClass())) + val obj = instance.deserialize[ContainsPrimitiveClass](instance.serialize( + new ContainsPrimitiveClass())) // enforce class cast obj.getClass }