Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-12363][Mllib][Backport-1.3] Remove setRun and fix PowerIterationClustering failed test #11265

Closed
wants to merge 3 commits into from

Conversation

@viirya
Copy link
Member

viirya commented Feb 19, 2016

What changes were proposed in this pull request?

Backport JIRA-SPARK-12363 to branch-1.3.

How was the this patch tested?

Unit test.

cc @mengxr

viirya and others added 3 commits Dec 31, 2015
Conflicts:
	mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala
…PIC paper

Conflicts:
	examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala
	mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala
	mllib/src/test/scala/org/apache/spark/mllib/clustering/PowerIterationClusteringSuite.scala
@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 19, 2016

Test build #51544 has finished for PR 11265 at commit ec076dd.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@viirya

This comment has been minimized.

Copy link
Member Author

viirya commented Feb 19, 2016

retest this please.

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 19, 2016

Test build #51557 has finished for PR 11265 at commit ec076dd.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@viirya

This comment has been minimized.

Copy link
Member Author

viirya commented Feb 21, 2016

Don't know why test_reduce_by_key_and_window_with_none_invFunc in pyspark/streaming/tests.py is failed. This PR doesn't touch streaming code...

@mengxr

This comment has been minimized.

Copy link
Contributor

mengxr commented Feb 23, 2016

test this please

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 23, 2016

Test build #51749 has finished for PR 11265 at commit ec076dd.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@viirya

This comment has been minimized.

Copy link
Member Author

viirya commented Feb 23, 2016

It failed at the same streaming python test. I will run that test locally with clear branch-1.3 codebase to see if it can pass.

@viirya

This comment has been minimized.

Copy link
Member Author

viirya commented Feb 23, 2016

Roughly check the git log, I found that the failed test is committed in latest commit at branch-1.3.

@viirya

This comment has been minimized.

Copy link
Member Author

viirya commented Feb 24, 2016

This test fails at clearly checkouted branch-1.3 codebase. We should open another PR to fix it...

@viirya

This comment has been minimized.

Copy link
Member Author

viirya commented Feb 24, 2016

Open #11339 for the failed test. Once the PR is merged, this should pass tests.

@mengxr

This comment has been minimized.

Copy link
Contributor

mengxr commented Feb 25, 2016

test this please

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 25, 2016

Test build #51999 has finished for PR 11265 at commit ec076dd.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@viirya

This comment has been minimized.

Copy link
Member Author

viirya commented Feb 26, 2016

retest this please.

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Feb 26, 2016

Test build #52017 has finished for PR 11265 at commit ec076dd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Feb 26, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52017/
Test FAILed.

asfgit pushed a commit that referenced this pull request Feb 26, 2016
…tionClustering failed test

## What changes were proposed in this pull request?

Backport JIRA-SPARK-12363 to branch-1.3.

## How was the this patch tested?

Unit test.

cc mengxr

Author: Liang-Chi Hsieh <viirya@gmail.com>
Author: Xiangrui Meng <meng@databricks.com>

Closes #11265 from viirya/backport-12363-1.3 and squashes the following commits:

ec076dd [Liang-Chi Hsieh] Fix scala style.
7a3ef5f [Xiangrui Meng] use Graph instead of GraphImpl and update tests and example based on PIC paper
b86018d [Liang-Chi Hsieh] Remove setRun and fix PowerIterationClustering failed test.
@mengxr

This comment has been minimized.

Copy link
Contributor

mengxr commented Feb 26, 2016

The build actually passed. I'm merging this one in. Thanks for backporting the fix! Could you close this PR?

@viirya

This comment has been minimized.

Copy link
Member Author

viirya commented Feb 26, 2016

@mengxr Thanks!

@viirya viirya closed this Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.