Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13475] [TESTS] [SQL] HiveCompatibilitySuite should still run in PR builder even if a PR only changes sql/core #11351

Closed
wants to merge 1 commit into from

Conversation

@yhuai
Copy link
Contributor

yhuai commented Feb 24, 2016

What changes were proposed in this pull request?

HiveCompatibilitySuite should still run in PR build even if a PR only changes sql/core. So, I am going to remove ExtendedHiveTest annotation from HiveCompatibilitySuite.

https://issues.apache.org/jira/browse/SPARK-13475

@yhuai

This comment has been minimized.

Copy link
Contributor Author

yhuai commented Feb 24, 2016

@@ -30,7 +30,6 @@ import org.apache.spark.tags.ExtendedHiveTest
/**
* Runs the test cases that are included in the hive distribution.
*/
@ExtendedHiveTest

This comment has been minimized.

Copy link
@JoshRosen

JoshRosen Feb 24, 2016

Contributor

You could also remove the import from this file.

This comment has been minimized.

Copy link
@yhuai

yhuai Feb 24, 2016

Author Contributor

OK. Removed.

@JoshRosen

This comment has been minimized.

Copy link
Contributor

JoshRosen commented Feb 24, 2016

LGTM. HiveCompatibilitySuite is much faster these days, so this seems fine and is necessary given some of the test coverage gaps in other suites.

@JoshRosen

This comment has been minimized.

Copy link
Contributor

JoshRosen commented Feb 24, 2016

Jenkins, retest this please.

@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Feb 24, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51903/
Test FAILed.

asfgit pushed a commit that referenced this pull request Feb 24, 2016
…PR builder even if a PR only changes sql/core

## What changes were proposed in this pull request?

`HiveCompatibilitySuite` should still run in PR build even if a PR only changes sql/core. So, I am going to remove `ExtendedHiveTest` annotation from `HiveCompatibilitySuite`.

https://issues.apache.org/jira/browse/SPARK-13475

Author: Yin Huai <yhuai@databricks.com>

Closes #11351 from yhuai/SPARK-13475.

(cherry picked from commit bc35380)
Signed-off-by: Yin Huai <yhuai@databricks.com>
@asfgit asfgit closed this in bc35380 Feb 24, 2016
@yhuai yhuai deleted the yhuai:SPARK-13475 branch Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.