From 9d4f7a8cf20bcd1f6ede46097406f235f3581b3b Mon Sep 17 00:00:00 2001 From: WeichenXu Date: Wed, 13 Jul 2016 22:09:12 -0700 Subject: [PATCH] fix L2 reg in linearRegression when standarlization is false --- .../scala/org/apache/spark/ml/regression/LinearRegression.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala b/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala index a0ff7f07aa3dd..0b80a143e029f 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala @@ -986,7 +986,7 @@ private class LeastSquaresCostFun( // perform this reverse standardization by penalizing each component // differently to get effectively the same objective function when // the training dataset is not standardized. - val temp = value / (featuresStd(index) * featuresStd(index)) + val temp = value * (featuresStd(index) * featuresStd(index)) totalGradientArray(index) += effectiveL2regParam * temp value * temp } else {