Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-16939][SQL] Fix build error by using `Tuple1` explicitly in StringFunctionsSuite #14526

Closed
wants to merge 1 commit into from

Conversation

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Aug 7, 2016

What changes were proposed in this pull request?

This PR aims to fix a build error on branch 1.6 at 8d87252, but I think we had better have this consistently in master branch, too. It's because there exist other ongoing PR (#14525) about this.

https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-1.6-compile-maven-with-yarn-2.3/286/console

[error] /home/jenkins/workspace/spark-branch-1.6-compile-maven-with-yarn-2.3/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:82: value toDF is not a member of Seq[String]
[error]     val df = Seq("aaaac").toDF("s")
[error]                           ^

How was this patch tested?

After passing Jenkins, run compilation test on branch 1.6.

build/mvn -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install
@srowen

This comment has been minimized.

Copy link
Member

srowen commented Aug 7, 2016

Ah, shoot, that would be my fault. I am not sure why it would only fail for 1.6? let me also look into it. Thanks for the catch.

@dongjoon-hyun

This comment has been minimized.

Copy link
Member Author

dongjoon-hyun commented Aug 7, 2016

Oh, thank you, @srowen !

@dongjoon-hyun

This comment has been minimized.

Copy link
Member Author

dongjoon-hyun commented Aug 7, 2016

Until today, I also guessed that master branch does not handle this.

@@ -95,7 +95,7 @@ class StringFunctionsSuite extends QueryTest with SharedSQLContext {
}

test("non-matching optional group") {
val df = Seq("aaaac").toDF("s")
val df = Seq(Tuple1("aaaac")).toDF("s")

This comment has been minimized.

Copy link
@srowen

srowen Aug 7, 2016

Member

OK, I guess that Scala 2.11 has an implicit conversion that Scala 2.10 does not that would make this conversion automatically, hence the PR builder succeeded. We could also just add a dummy column in the example, but I suppose this is the best way to ensure that the fix works in 1.6, and also makes the test a little more robust. LGTM, thanks.

This comment has been minimized.

Copy link
@dongjoon-hyun

dongjoon-hyun Aug 7, 2016

Author Member

Thank you, @srowen .

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Aug 7, 2016

Test build #63328 has finished for PR 14526 at commit 1256d67.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@asfgit asfgit closed this in a16983c Aug 7, 2016
asfgit pushed a commit that referenced this pull request Aug 7, 2016
…ringFunctionsSuite

## What changes were proposed in this pull request?

This PR aims to fix a build error on branch 1.6 at 8d87252, but I think we had better have this consistently in master branch, too. It's because there exist other ongoing PR (#14525) about this.

https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-1.6-compile-maven-with-yarn-2.3/286/console

```scala
[error] /home/jenkins/workspace/spark-branch-1.6-compile-maven-with-yarn-2.3/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:82: value toDF is not a member of Seq[String]
[error]     val df = Seq("aaaac").toDF("s")
[error]                           ^
```

## How was this patch tested?

After passing Jenkins, run compilation test on branch 1.6.
```
build/mvn -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install
```

Author: Dongjoon Hyun <dongjoon@apache.org>

Closes #14526 from dongjoon-hyun/SPARK-16939.

(cherry picked from commit a16983c)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen

This comment has been minimized.

Copy link
Member

srowen commented Aug 7, 2016

Merged to master/2.0/1.6

asfgit pushed a commit that referenced this pull request Aug 7, 2016
…ringFunctionsSuite

## What changes were proposed in this pull request?

This PR aims to fix a build error on branch 1.6 at 8d87252, but I think we had better have this consistently in master branch, too. It's because there exist other ongoing PR (#14525) about this.

https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-1.6-compile-maven-with-yarn-2.3/286/console

```scala
[error] /home/jenkins/workspace/spark-branch-1.6-compile-maven-with-yarn-2.3/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:82: value toDF is not a member of Seq[String]
[error]     val df = Seq("aaaac").toDF("s")
[error]                           ^
```

## How was this patch tested?

After passing Jenkins, run compilation test on branch 1.6.
```
build/mvn -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install
```

Author: Dongjoon Hyun <dongjoon@apache.org>

Closes #14526 from dongjoon-hyun/SPARK-16939.

(cherry picked from commit a16983c)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@dongjoon-hyun

This comment has been minimized.

Copy link
Member Author

dongjoon-hyun commented Aug 7, 2016

Thank you for review and merging, @srowen !

zzcclp added a commit to zzcclp/spark that referenced this pull request Aug 8, 2016
…ringFunctionsSuite

## What changes were proposed in this pull request?

This PR aims to fix a build error on branch 1.6 at apache@8d87252, but I think we had better have this consistently in master branch, too. It's because there exist other ongoing PR (apache#14525) about this.

https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-1.6-compile-maven-with-yarn-2.3/286/console

```scala
[error] /home/jenkins/workspace/spark-branch-1.6-compile-maven-with-yarn-2.3/sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:82: value toDF is not a member of Seq[String]
[error]     val df = Seq("aaaac").toDF("s")
[error]                           ^
```

## How was this patch tested?

After passing Jenkins, run compilation test on branch 1.6.
```
build/mvn -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install
```

Author: Dongjoon Hyun <dongjoon@apache.org>

Closes apache#14526 from dongjoon-hyun/SPARK-16939.

(cherry picked from commit a16983c)
Signed-off-by: Sean Owen <sowen@cloudera.com>
(cherry picked from commit a3b06ae)
@dongjoon-hyun dongjoon-hyun deleted the dongjoon-hyun:SPARK-16939 branch Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.