Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-18002][SQL] Pruning unnecessary IsNotNull predicates from Filter #15547

Closed
wants to merge 1 commit into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Oct 19, 2016

What changes were proposed in this pull request?

In PruneFilters rule, we can prune unnecessary IsNotNull predicates if the predicate in IsNotNull is not nullable.

How was this patch tested?

Jenkins tests.

Please review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark before opening a pull request.

@SparkQA
Copy link

SparkQA commented Oct 19, 2016

Test build #67169 has finished for PR 15547 at commit a264eba.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Oct 19, 2016

cc @cloud-fan

@cloud-fan
Copy link
Contributor

IsNull/IsNotNull may be optimized to literals in the NullPropagation rule, do you have an end-to-end example to show that your PR fixes some problems?

@viirya
Copy link
Member Author

viirya commented Oct 19, 2016

@cloud-fan yeah, I've not noticed NullPropagation already has rule for this. Close this now.

@viirya viirya closed this Oct 19, 2016
@viirya viirya deleted the prune-isnotnull branch December 27, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants