Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-19220][UI] Make redirection to HTTPS apply to all URIs. (branch-2.0) #16717

Closed
wants to merge 1 commit into from

Conversation

@vanzin
Copy link
Contributor

commented Jan 27, 2017

The redirect handler was installed only for the root of the server;
any other context ended up being served directly through the HTTP
port. Since every sub page (e.g. application UIs in the history
server) is a separate servlet context, this meant that everything
but the root was accessible via HTTP still.

The change adds separate names to each connector, and binds contexts
to specific connectors so that content is only served through the
HTTPS connector when it's enabled. In that case, the only thing that
binds to the HTTP connector is the redirect handler.

Tested with new unit tests and by checking a live history server.

(cherry picked from commit 59502bb)

[SPARK-19220][UI] Make redirection to HTTPS apply to all URIs. (branc…
…h-2.0)

The redirect handler was installed only for the root of the server;
any other context ended up being served directly through the HTTP
port. Since every sub page (e.g. application UIs in the history
server) is a separate servlet context, this meant that everything
but the root was accessible via HTTP still.

The change adds separate names to each connector, and binds contexts
to specific connectors so that content is only served through the
HTTPS connector when it's enabled. In that case, the only thing that
binds to the HTTP connector is the redirect handler.

Tested with new unit tests and by checking a live history server.

(cherry picked from commit 59502bb)
@SparkQA

This comment has been minimized.

Copy link

commented Jan 27, 2017

Test build #72060 has finished for PR 16717 at commit ddd7727.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@vanzin

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2017

Merging to 2.0.

@vanzin vanzin closed this Jan 27, 2017

asfgit pushed a commit that referenced this pull request Jan 27, 2017
[SPARK-19220][UI] Make redirection to HTTPS apply to all URIs. (branc…
…h-2.0)

The redirect handler was installed only for the root of the server;
any other context ended up being served directly through the HTTP
port. Since every sub page (e.g. application UIs in the history
server) is a separate servlet context, this meant that everything
but the root was accessible via HTTP still.

The change adds separate names to each connector, and binds contexts
to specific connectors so that content is only served through the
HTTPS connector when it's enabled. In that case, the only thing that
binds to the HTTP connector is the redirect handler.

Tested with new unit tests and by checking a live history server.

(cherry picked from commit 59502bb)

Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes #16717 from vanzin/SPARK-19220_2.0.

@vanzin vanzin deleted the vanzin:SPARK-19220_2.0 branch Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.