From 7a8b4458f2803bf57b4d34a4bdcbd68a4f6dce9b Mon Sep 17 00:00:00 2001 From: hyukjinkwon Date: Fri, 23 Jun 2017 14:25:40 +0900 Subject: [PATCH 1/4] Handle unknown error codes in Jenkins rather then leaving incomplete comment in PRs --- dev/run-tests-jenkins.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dev/run-tests-jenkins.py b/dev/run-tests-jenkins.py index 53061bc947e5f..914eb93622d51 100755 --- a/dev/run-tests-jenkins.py +++ b/dev/run-tests-jenkins.py @@ -137,7 +137,9 @@ def run_tests(tests_timeout): if test_result_code == 0: test_result_note = ' * This patch passes all tests.' else: - test_result_note = ' * This patch **fails %s**.' % failure_note_by_errcode[test_result_code] + note = failure_note_by_errcode.get( + test_result_code, "due to an unknown error code, %s" % test_result_code) + test_result_note = ' * This patch **fails %s**.' % note return [test_result_code, test_result_note] From 98be77e658c65a9b0a478e43942f880af21d2887 Mon Sep 17 00:00:00 2001 From: hyukjinkwon Date: Fri, 23 Jun 2017 14:30:49 +0900 Subject: [PATCH 2/4] Print out an unknown error code, -9. --- dev/run-tests-jenkins.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dev/run-tests-jenkins.py b/dev/run-tests-jenkins.py index 914eb93622d51..501b07ea9da89 100755 --- a/dev/run-tests-jenkins.py +++ b/dev/run-tests-jenkins.py @@ -114,6 +114,8 @@ def run_tests(tests_timeout): tests_timeout, os.path.join(SPARK_HOME, 'dev', 'run-tests')]).wait() + test_result_code = -9 + failure_note_by_errcode = { 1: 'executing the `dev/run-tests` script', # error to denote run-tests script failures ERROR_CODES["BLOCK_GENERAL"]: 'some tests', From 0938532e2a373d3982e4f7b21ad6b14994417e62 Mon Sep 17 00:00:00 2001 From: hyukjinkwon Date: Fri, 23 Jun 2017 14:31:55 +0900 Subject: [PATCH 3/4] Print out an unknown error code, -10. --- dev/run-tests-jenkins.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/run-tests-jenkins.py b/dev/run-tests-jenkins.py index 501b07ea9da89..b1c6410f5fafb 100755 --- a/dev/run-tests-jenkins.py +++ b/dev/run-tests-jenkins.py @@ -114,7 +114,7 @@ def run_tests(tests_timeout): tests_timeout, os.path.join(SPARK_HOME, 'dev', 'run-tests')]).wait() - test_result_code = -9 + test_result_code = -10 failure_note_by_errcode = { 1: 'executing the `dev/run-tests` script', # error to denote run-tests script failures From cbf3517df657fe0767be2ae12f80da182c0a2a91 Mon Sep 17 00:00:00 2001 From: hyukjinkwon Date: Fri, 23 Jun 2017 14:33:17 +0900 Subject: [PATCH 4/4] Come back to the original state. --- dev/run-tests-jenkins.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/dev/run-tests-jenkins.py b/dev/run-tests-jenkins.py index b1c6410f5fafb..914eb93622d51 100755 --- a/dev/run-tests-jenkins.py +++ b/dev/run-tests-jenkins.py @@ -114,8 +114,6 @@ def run_tests(tests_timeout): tests_timeout, os.path.join(SPARK_HOME, 'dev', 'run-tests')]).wait() - test_result_code = -10 - failure_note_by_errcode = { 1: 'executing the `dev/run-tests` script', # error to denote run-tests script failures ERROR_CODES["BLOCK_GENERAL"]: 'some tests',