Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21912][SQL][FOLLOW-UP] ORC/Parquet table should not create invalid column names #19562

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@dongjoon-hyun
Copy link
Member

commented Oct 23, 2017

What changes were proposed in this pull request?

During SPARK-21912, we skipped testing 'ADD COLUMNS' on ORC tables due to ORC limitation. Since SPARK-21929 is resolved now, we can test both ORC and PARQUET completely.

How was this patch tested?

Pass the updated test case.

@gatorsmile
Copy link
Member

left a comment

LGTM pending test.

@SparkQA

This comment has been minimized.

Copy link

commented Oct 23, 2017

Test build #82996 has finished for PR 19562 at commit 430af34.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@dongjoon-hyun

This comment has been minimized.

Copy link
Member Author

commented Oct 24, 2017

Thank you for review and approval, @gatorsmile !

@gatorsmile

This comment has been minimized.

Copy link
Member

commented Oct 24, 2017

Thanks! Merged to master.

@asfgit asfgit closed this in 884d4f9 Oct 24, 2017

@dongjoon-hyun

This comment has been minimized.

Copy link
Member Author

commented Oct 24, 2017

Thank you!

@dongjoon-hyun dongjoon-hyun deleted the dongjoon-hyun:SPARK-21912-2 branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.