Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-23406][SS] Enable stream-stream self-joins for branch-2.3 #20755

Closed
wants to merge 1 commit into from
Closed

[SPARK-23406][SS] Enable stream-stream self-joins for branch-2.3 #20755

wants to merge 1 commit into from

Conversation

tdas
Copy link
Contributor

@tdas tdas commented Mar 7, 2018

What changes were proposed in this pull request?

This is limited but safe-to-backport version of self-join-fix made in #20598
That PR solved two bugs

  1. Add MultiInstanceRelation trait to leaf logical nodes to allow resolution - This is the major fix required to allow streaming self-joins, and is safe to backport.
  2. Fix attribute rewriting in MicroBatchExecution when micro-batch plans are spliced into the streaming logical plan - This is a minor fix that is not safe to backport. Without this fix only a very small fraction self-join cases will have issues, but those issues may lead to incorrect results.

How was this patch tested?

New unit test

@tdas tdas closed this Mar 7, 2018
@SparkQA
Copy link

SparkQA commented Mar 7, 2018

Test build #88030 has finished for PR 20755 at commit 484babb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdas @SparkQA