New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-19724][SQL][FOLLOW-UP]Check location of managed table when ignoreIfExists is true #21001

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@gengliangwang
Contributor

gengliangwang commented Apr 7, 2018

What changes were proposed in this pull request?

In the PR #20886, I mistakenly check the table location only when ignoreIfExists is false, which was following the original deprecated PR.
That was wrong. When ignoreIfExists is true and the target table doesn't exist, we should also check the table location. In other word, ignoreIfExists has nothing to do with table location validation.
This is a follow-up PR to fix the mistake.

How was this patch tested?

Add one unit test.

@gengliangwang

This comment has been minimized.

Show comment
Hide comment
@gengliangwang
Contributor

gengliangwang commented Apr 7, 2018

@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Apr 7, 2018

Test build #89011 has finished for PR 21001 at commit 3d1c909.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

SparkQA commented Apr 7, 2018

Test build #89011 has finished for PR 21001 at commit 3d1c909.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@gengliangwang

This comment has been minimized.

Show comment
Hide comment
@gengliangwang

gengliangwang Apr 7, 2018

Contributor

retest this please.

Contributor

gengliangwang commented Apr 7, 2018

retest this please.

@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Apr 7, 2018

Test build #89017 has finished for PR 21001 at commit 3d1c909.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

SparkQA commented Apr 7, 2018

Test build #89017 has finished for PR 21001 at commit 3d1c909.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Apr 9, 2018

Test build #89050 has finished for PR 21001 at commit 3fe648f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

SparkQA commented Apr 9, 2018

Test build #89050 has finished for PR 21001 at commit 3fe648f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Apr 9, 2018

Test build #89072 has finished for PR 21001 at commit 1e27cc8.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

SparkQA commented Apr 9, 2018

Test build #89072 has finished for PR 21001 at commit 1e27cc8.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Apr 9, 2018

Test build #89071 has finished for PR 21001 at commit 577a399.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

SparkQA commented Apr 9, 2018

Test build #89071 has finished for PR 21001 at commit 577a399.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Apr 10, 2018

Test build #89080 has finished for PR 21001 at commit 3f3391b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

SparkQA commented Apr 10, 2018

Test build #89080 has finished for PR 21001 at commit 3f3391b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Apr 10, 2018

Test build #89115 has finished for PR 21001 at commit ffd0c66.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

SparkQA commented Apr 10, 2018

Test build #89115 has finished for PR 21001 at commit ffd0c66.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@gatorsmile

This comment has been minimized.

Show comment
Hide comment
@gatorsmile

gatorsmile Apr 10, 2018

Member

LGTM

Thanks! Merged to master.

Member

gatorsmile commented Apr 10, 2018

LGTM

Thanks! Merged to master.

@asfgit asfgit closed this in e179658 Apr 10, 2018

@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Apr 10, 2018

Test build #89124 has finished for PR 21001 at commit c4f359a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

SparkQA commented Apr 10, 2018

Test build #89124 has finished for PR 21001 at commit c4f359a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

pepinoflo added a commit to pepinoflo/spark that referenced this pull request May 15, 2018

[SPARK-19724][SQL][FOLLOW-UP] Check location of managed table when ig…
…noreIfExists is true

## What changes were proposed in this pull request?

In the PR apache#20886, I mistakenly check the table location only when `ignoreIfExists` is false, which was following the original deprecated PR.
That was wrong. When `ignoreIfExists` is true and the target table doesn't exist, we should also check the table location. In other word, **`ignoreIfExists` has nothing to do with table location validation**.
This is a follow-up PR to fix the mistake.

## How was this patch tested?

Add one unit test.

Author: Gengliang Wang <gengliang.wang@databricks.com>

Closes apache#21001 from gengliangwang/SPARK-19724-followup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment