[SPARK-24716][TESTS][FOLLOW-UP] Test Hive metastore schema and parquet schema are in different letter cases #22267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #95415 has finished for PR 22267 at commit
|
|
cc @cloud-fan |
cloud-fan
reviewed
Aug 30, 2018
| @@ -1021,6 +1021,18 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with SharedSQLContex | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| test("SPARK-25206: wrong records are returned when Hive metastore schema and parquet schema " + | |||
There was a problem hiding this comment.
this is a end-to-end test and should not be put here. How about HiveParquetSuite
|
Test build #95453 has finished for PR 22267 at commit
|
|
thanks, merging to master! |
fjh100456
pushed a commit
to fjh100456/spark
that referenced
this pull request
Aug 31, 2018
…t schema are in different letter cases ## What changes were proposed in this pull request? Since apache#21696. Spark uses Parquet schema instead of Hive metastore schema to do pushdown. That change can avoid wrong records returned when Hive metastore schema and parquet schema are in different letter cases. This pr add a test case for it. More details: https://issues.apache.org/jira/browse/SPARK-25206 ## How was this patch tested? unit tests Closes apache#22267 from wangyum/SPARK-24716-TESTS. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since #21696. Spark uses Parquet schema instead of Hive metastore schema to do pushdown.
That change can avoid wrong records returned when Hive metastore schema and parquet schema are in different letter cases. This pr add a test case for it.
More details:
https://issues.apache.org/jira/browse/SPARK-25206
How was this patch tested?
unit tests