Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-23886][SS] Update query status for ContinuousExecution #23095

Closed
wants to merge 3 commits into from

Conversation

@gaborgsomogyi
Copy link
Contributor

gaborgsomogyi commented Nov 20, 2018

What changes were proposed in this pull request?

Added query status updates to ContinuousExecution.

How was this patch tested?

Existing unit tests + added ContinuousQueryStatusAndProgressSuite.

@gaborgsomogyi

This comment has been minimized.

Copy link
Contributor Author

gaborgsomogyi commented Nov 20, 2018

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Nov 20, 2018

Test build #99056 has finished for PR 23095 at commit 5b743ab.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
Copy link
Contributor

attilapiros left a comment

Small suggestion regarding comment wording, besides that LGTM.

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Nov 20, 2018

Test build #99071 has finished for PR 23095 at commit 44b3c91.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
Copy link
Contributor

HeartSaVioR left a comment

+1 LGTM.

Copy link
Contributor

jose-torres left a comment

lgtm

@SparkQA

This comment has been minimized.

Copy link

SparkQA commented Nov 22, 2018

Test build #99192 has finished for PR 23095 at commit 86539d0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@gaborgsomogyi

This comment has been minimized.

Copy link
Contributor Author

gaborgsomogyi commented Nov 27, 2018

@gaborgsomogyi

This comment has been minimized.

Copy link
Contributor Author

gaborgsomogyi commented Dec 13, 2018

cc @vanzin

@vanzin

This comment has been minimized.

Copy link
Contributor

vanzin commented Dec 14, 2018

Looks good. I'd have chosen a shorter test name, but no biggie.

Merging to master.

@asfgit asfgit closed this in 362e472 Dec 14, 2018
holdenk added a commit to holdenk/spark that referenced this pull request Jan 5, 2019
## What changes were proposed in this pull request?

Added query status updates to ContinuousExecution.

## How was this patch tested?

Existing unit tests + added ContinuousQueryStatusAndProgressSuite.

Closes apache#23095 from gaborgsomogyi/SPARK-23886.

Authored-by: Gabor Somogyi <gabor.g.somogyi@gmail.com>
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
stczwd added a commit to stczwd/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

Added query status updates to ContinuousExecution.

## How was this patch tested?

Existing unit tests + added ContinuousQueryStatusAndProgressSuite.

Closes apache#23095 from gaborgsomogyi/SPARK-23886.

Authored-by: Gabor Somogyi <gabor.g.somogyi@gmail.com>
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.