[MINOR][DOC] Documentation on JVM options for SBT #23615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
requested changes
Jan 22, 2019
|
@srowen I've updated the doc. Please tell me if there are any errors. (A bit embarrassing 囧 ) |
srowen
approved these changes
Jan 22, 2019
|
Test build #101539 has finished for PR 23615 at commit
|
|
Test build #101543 has finished for PR 23615 at commit
|
|
Hi, @sadhen . Could you update the section, |
|
I think it's fine; I tested that indeed it causes SBT to use the supplied settings. I'll just edit the description. |
|
Thanks, @srowen . |
|
Merged to master |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Documentation and .gitignore ## How was this patch tested? Manual test that SBT honors the settings in .jvmopts if present Closes apache#23615 from sadhen/impr/gitignore. Authored-by: Darcy Shen <sadhen@zoho.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
|
Is there any reason not to just check in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Documentation and .gitignore
How was this patch tested?
Manual test that SBT honors the settings in .jvmopts if present