Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-27722][SQL] removed the unsed "UnsafeKeyValueSorter" file. #24622

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@shivusondur
Copy link
Contributor

commented May 16, 2019

What changes were proposed in this pull request?

removed the unused "UnsafeKeyValueSorter.java" file

How was this patch tested?

Ran Compilation and UT locally.

Please review http://spark.apache.org/contributing.html before opening a pull request.

@HyukjinKwon

This comment has been minimized.

Copy link
Member

commented May 16, 2019

ok to test

@SparkQA

This comment has been minimized.

Copy link

commented May 16, 2019

Test build #105435 has finished for PR 24622 at commit 0a2b132.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@shivusondur

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

please retest this

@shivusondur shivusondur force-pushed the shivusondur:jira27722 branch from 0a2b132 to 3e30a98 May 16, 2019

@shivusondur shivusondur reopened this May 16, 2019

@shivusondur

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

@HyukjinKwon
Test Case failure is not relevant to this MR,
please retest

@viirya

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

retest this please.

@cloud-fan

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

ok to test

@HyukjinKwon
Copy link
Member

left a comment

Looks good if build and tests pass. I think there's no point of keeping unused private codes in Spark - it just makes us hard to read the codes.

@SparkQA

This comment has been minimized.

Copy link

commented May 16, 2019

Test build #105443 has finished for PR 24622 at commit f3f9244.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@viirya

viirya approved these changes May 16, 2019

Copy link
Contributor

left a comment

The build and tests verify this class is not used. If no special reason to keep it, I think it is fine to remove it.

@cloud-fan

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

thanks, merging to master!

@cloud-fan cloud-fan closed this in c6a45e6 May 16, 2019

@shivusondur

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

@HyukjinKwon , @cloud-fan , @viirya
thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.