[SPARK-28159][ML][FOLLOWUP] fix typo & (0 until v.size).toList => List.range(0, v.size) #25129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #107578 has finished for PR 25129 at commit
|
| @@ -490,7 +490,7 @@ abstract class LDAModel private[ml] ( | |||
| Vectors.zeros(k) | |||
| } else { | |||
| val (ids: List[Int], cts: Array[Double]) = vector match { | |||
| case v: DenseVector => ((0 until v.size).toList, v.values) | |||
| case v: DenseVector => (List.range(0, v.size), v.values) | |||
There was a problem hiding this comment.
Please update the PR title or remove this from this PR.
There was a problem hiding this comment.
I think this is OK, as it mirrors a similar change (optimization) we made in the previous PR. You're right it's orthogonal to the typo fix, but will be fine to add.
zhengruifeng
changed the title
srowen
approved these changes
Jul 12, 2019
dongjoon-hyun
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
Yep. Thank you, @zhengruifeng and @srowen .
+1, LGTM, too. Merged to master.
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jul 18, 2019
…t.range(0, v.size) ## What changes were proposed in this pull request? fix typo in spark-28159 `transfromWithMean` -> `transformWithMean` ## How was this patch tested? existing test Closes apache#25129 from zhengruifeng/to_ml_vec_cleanup. Authored-by: zhengruifeng <ruifengz@foxmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix typo in spark-28159
transfromWithMean->transformWithMeanHow was this patch tested?
existing test