New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-25584][ML][DOC] datasource for libsvm user guide #25286
Conversation
@@ -1,7 +1,7 @@ | |||
- text: Basic statistics | |||
url: ml-statistics.html | |||
- text: Data sources | |||
url: ml-datasource | |||
url: ml-datasource.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The orginal url: ml-datasource
is incorrect that the generated url lose suffix .html
This do not matter in the offical web, since it seems that model web browser will automatically add the suffix.
However, in the locally built docs, we can not open the ml-datasource link file:///Users/xxx/Dev/OpenSource/spark/docs/_site/ml-datasource
from page file:///Users/xxx/Dev/OpenSource/spark/docs/_site/ml-guide.html
.
ping @mengxr @WeichenXu123 ? would you mind help reviewing this? thanks in advance! |
Test build #108321 has finished for PR 25286 at commit
|
Test build #108323 has finished for PR 25286 at commit
|
(ignore the logs above. I was testing merge script Python 3 compatibility) |
Merged to master |
What changes were proposed in this pull request?
it seems that doc for libsvm datasource is not added in #22675.
This pr is to add it.
How was this patch tested?
doc built locally