Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-28919][INFRA] Add more profiles for JDK8/11 build test for Github workflow #25624

Closed
wants to merge 1 commit into from
Closed

[SPARK-28919][INFRA] Add more profiles for JDK8/11 build test for Github workflow #25624

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Aug 29, 2019

What changes were proposed in this pull request?

This PR aims to add -Pyarn -Pmesos -Pkubernetes -Phive -Phive-thriftserver -Phadoop-3.2 -Phadoop-cloud profiles to GitHub workflow conf.

Why are the changes needed?

Currently, we build with JDK8 and test with JDK8/11 in Jenkins.
And, we use GitHub Workflow for JDK8/JDK11 building test.
To test JDK11 fully, we need to enable hive and hadoop-3.2 profiles for Hive 2.3.6 and Hadoop 3.2. Also, this PR adds all resource manager modules, too.

Does this PR introduce any user-facing change?

No. In addition, Jenkins workload will be the same because this is specific to GitHub workflow.

How was this patch tested?

See the GitHub workflow run result.

-Pyarn -Pmesos -Pkubernetes -Phive -Phive-thriftserver -Phadoop-3.2 -Phadoop-cloud
@dongjoon-hyun dongjoon-hyun changed the title Add more profiles for JDK8/11 build test [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test Aug 29, 2019
@dongjoon-hyun
Copy link
Member Author

Hi, @dbtsai . Is there a way to trigger this on PR?

@dbtsai
Copy link
Member

dbtsai commented Aug 29, 2019

@dongjoon-hyun yes, you can.

See

https://help.github.com/en/articles/events-that-trigger-workflows

make it on pull request.

Thanks.

@dongjoon-hyun
Copy link
Member Author

Thank you, @dbtsai .

@SparkQA
Copy link

SparkQA commented Aug 30, 2019

Test build #109920 has finished for PR 25624 at commit 04bb2b0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Aug 30, 2019

retest this please.

@dongjoon-hyun
Copy link
Member Author

Thank you for retriggering, @viirya .

@HyukjinKwon HyukjinKwon changed the title [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test for Github workflow Aug 30, 2019
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems fine if tests pass

@dongjoon-hyun
Copy link
Member Author

Thank you for review and updating PR title, @HyukjinKwon .

@SparkQA
Copy link

SparkQA commented Aug 30, 2019

Test build #109924 has finished for PR 25624 at commit 04bb2b0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Thank you all.
Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-JDK11-HIVE branch August 30, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants