Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][SPARK-29564][SQL] Cluster deploy mode should support Spark Thrift server #26223

Closed
wants to merge 1 commit into from

Conversation

LantaoJin
Copy link
Contributor

@LantaoJin LantaoJin commented Oct 23, 2019

What changes were proposed in this pull request?

Cluster deploy mode is not applicable to Spark Thrift server now. This restriction is too rude.
In our production, we use multiple Spark Thrift servers as long running services which are used yarn-cluster mode to launch. The life cycle of STS is managed by upper layer manager system which is also used to dispatcher user's JDBC connection to applicable STS.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Manually test with command:

sbin/start-thriftserver.sh --master yarn --deploy-mode cluster --queue myqueue

@LantaoJin LantaoJin changed the title [SPARK-29564][SQL] Cluster deploy mode should support Spark Thrift server [WIP][SPARK-29564][SQL] Cluster deploy mode should support Spark Thrift server Oct 23, 2019
@SparkQA
Copy link

SparkQA commented Oct 23, 2019

Test build #112525 has finished for PR 26223 at commit 240f636.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor

How do you get thrift ip/port in cluster mode?

@LantaoJin
Copy link
Contributor Author

I mark this to WIP since it needs more code to implement this feature. I will update a design doc in Jira soon.

@dongjoon-hyun
Copy link
Member

Hi, @LantaoJin .
I also have the same concern like @jerryshao .
I'm closing this PR for now. Please feel free to reopen this PR when you are ready.
Thanks!

@LantaoJin
Copy link
Contributor Author

thanks @dongjoon-hyun , I am busy with re-developing delta-lake in corp inner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants