Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-29941][SQL] Add ansi type aliases for char and decimal #26574

Closed
wants to merge 1 commit into from
Closed

[SPARK-29941][SQL] Add ansi type aliases for char and decimal #26574

wants to merge 1 commit into from

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Nov 18, 2019

What changes were proposed in this pull request?

Checked with SQL Standard and PostgreSQL

CHAR is equivalent to CHARACTER. DEC is equivalent to DECIMAL. INT is equivalent to INTEGER. VARCHAR is equivalent to CHARACTER VARYING. ...

postgres=# select dec '1.0';
numeric
---------
1.0
(1 row)

postgres=# select CHARACTER '. second';
  bpchar
----------
 . second
(1 row)

postgres=# select CHAR '. second';
  bpchar
----------
 . second
(1 row)

Why are the changes needed?

For better ansi support

Does this PR introduce any user-facing change?

yes, we add character as char and dec as decimal

How was this patch tested?

add ut

@yaooqinn
Copy link
Member Author

cc @cloud-fan @maropu, pre-discussion @ #26537 (comment), thanks.

@SparkQA
Copy link

SparkQA commented Nov 18, 2019

Test build #114012 has finished for PR 26574 at commit ea5b5a4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants