[SPARK-34132][DOCS][R] Update Roxygen version references to 7.1.1 #31200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero323
changed the title
Done @dongjoon-hyun |
|
Test build #134123 has finished for PR 31200 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
srowen
approved these changes
Jan 15, 2021
HyukjinKwon
approved these changes
Jan 15, 2021
dongjoon-hyun
approved these changes
Jan 16, 2021
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 16, 2021
### What changes were proposed in this pull request? This PR updates `roxygen2` version reference in docs and `DESCRIPTION` file. ### Why are the changes needed? According to information provided by shaneknapp (see [this comment](https://issues.apache.org/jira/browse/SPARK-30747?focusedCommentId=17265142&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17265142) to SPARK-30747) all workers use roxygen 7.1.1. In GitHub workflow we install the latest version https://github.com/apache/spark/blob/c75c29dcaa9458a9ce0dd7a4d5fafbffb4b7f6a6/.github/workflows/build_and_test.yml#L346 which [is also 7.1.1 at the moment](https://web.archive.org/web/20210115172522/https://cran.r-project.org/web/packages/roxygen2/). ### Does this PR introduce _any_ user-facing change? Docs and description mention currently used package verison. ### How was this patch tested? - `dev/lint-r`. - Manual check of command used in docs. Closes #31200 from zero323/ROXYGEN-VERSION-UPDATE-DOCS. Authored-by: zero323 <mszymkiewicz@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 66cc129) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
|
Thanks @dongjoon-hyun @HyukjinKwon @srowen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates
roxygen2version reference in docs andDESCRIPTIONfile.Why are the changes needed?
According to information provided by @shaneknapp (see this comment to SPARK-30747) all workers use roxygen 7.1.1.
In GitHub workflow we install the latest version
spark/.github/workflows/build_and_test.yml
Line 346 in c75c29d
which is also 7.1.1 at the moment.
Does this PR introduce any user-facing change?
Docs and description mention currently used package verison.
How was this patch tested?
dev/lint-r.