New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-36965][PYTHON] Extend python test runner by logging out the temp output files #34233
Conversation
Test build #144052 has finished for PR 34233 at commit
|
Kubernetes integration test starting |
Test build #144053 has finished for PR 34233 at commit
|
Kubernetes integration test status failure |
Kubernetes integration test starting |
Kubernetes integration test status failure |
cc @HyukjinKwon |
Looks fine |
Test build #144117 has finished for PR 34233 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes were proposed in this pull request?
Extending the python test runner by logging out the temp output files.
Why are the changes needed?
I was running a python test which was extremely slow and I was surprised the unit-tests.log has not been even created. Looked into the code and as I got the tests can be executed in parallel and each one has its own temporary output file which is only added to the unit-tests.log when a test is finished with a failure (after acquiring a lock to avoid parallel write on unit-tests.log).
To avoid such a confusion it would make sense to log out the path of those temporary output files this way when a test got stuck we can peek into its log file.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I was running the python tests: