New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-5882][GraphX] Add a test for GraphLoader.edgeListFile #4674
Conversation
@maropu in general you need a JIRA for non-trivial changes. However is this just a part of SPARK-5450 / #4244 ? |
oops, I missed it. |
Fixed. |
ok to test |
Test build #27719 has finished for PR 4674 at commit
|
@ankurdave are you progressing with this PR or should we close it? |
Test build #41382 has finished for PR 4674 at commit
|
import org.apache.spark.util.Utils | ||
import org.scalatest.FunSuite | ||
|
||
class GraphLoaderSuite extends FunSuite with LocalSparkContext { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is outdated. You now need to extend org.apache.spark.SparkFunSuite
instead of FunSuite
directly.
retest this please (this should fail scala style tests because of the issue I brought up) |
@maropu would you mind bringing this up to date in master? |
@andrewor14 okay |
cc5ac0b
to
520bb6b
Compare
@andrewor14 @ankurdave Fixed. Also, could you merge #4399? |
retest this please |
@andrewor14 Yes, LGTM |
retest this please |
Test build #2236 has finished for PR 4674 at commit
|
Merging into master |
No description provided.