Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-5882][GraphX] Add a test for GraphLoader.edgeListFile #4674

Closed
wants to merge 2 commits into from

Conversation

maropu
Copy link
Member

@maropu maropu commented Feb 18, 2015

No description provided.

@maropu maropu changed the title [GraphXAdd a test for GraphLoader.edgeListFile [GraphX] Add a test for GraphLoader.edgeListFile Feb 18, 2015
@srowen
Copy link
Member

srowen commented Feb 18, 2015

@maropu in general you need a JIRA for non-trivial changes. However is this just a part of SPARK-5450 / #4244 ?

@maropu
Copy link
Member Author

maropu commented Feb 18, 2015

oops, I missed it.
I'll fix it soon.

@maropu maropu changed the title [GraphX] Add a test for GraphLoader.edgeListFile [SPARK-5882][GraphX] Add a test for GraphLoader.edgeListFile Feb 18, 2015
@maropu
Copy link
Member Author

maropu commented Feb 18, 2015

Fixed.

@ankurdave
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Feb 19, 2015

Test build #27719 has finished for PR 4674 at commit cc5ac0b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class GraphLoaderSuite extends FunSuite with LocalSparkContext

@srowen
Copy link
Member

srowen commented Jul 17, 2015

@ankurdave are you progressing with this PR or should we close it?

@SparkQA
Copy link

SparkQA commented Aug 21, 2015

Test build #41382 has finished for PR 4674 at commit cc5ac0b.

  • This patch fails to build.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

import org.apache.spark.util.Utils
import org.scalatest.FunSuite

class GraphLoaderSuite extends FunSuite with LocalSparkContext {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is outdated. You now need to extend org.apache.spark.SparkFunSuite instead of FunSuite directly.

@andrewor14
Copy link
Contributor

retest this please (this should fail scala style tests because of the issue I brought up)

@andrewor14
Copy link
Contributor

@maropu would you mind bringing this up to date in master?
@ankurdave this looks like an OK change. Is it good to merge once it's rebased?

@maropu
Copy link
Member Author

maropu commented Dec 17, 2015

@andrewor14 okay

@maropu
Copy link
Member Author

maropu commented Dec 17, 2015

@andrewor14 @ankurdave Fixed. Also, could you merge #4399?

@andrewor14
Copy link
Contributor

retest this please

@ankurdave
Copy link
Contributor

@andrewor14 Yes, LGTM

@andrewor14
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Dec 19, 2015

Test build #2236 has finished for PR 4674 at commit c1e2303.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class GraphLoaderSuite extends SparkFunSuite with LocalSparkContext\n

@andrewor14
Copy link
Contributor

Merging into master

@asfgit asfgit closed this in 1eb90bc Dec 21, 2015
@maropu maropu deleted the AddGraphLoaderSuite branch July 5, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants