From bdf74d3e881708cd7d4fca7fadc5af266d484df2 Mon Sep 17 00:00:00 2001
From: Dongjoon Hyun <dongjoon@apache.org>
Date: Sun, 3 Aug 2025 18:05:22 -0700
Subject: [PATCH] [SPARK-53091][SQL] Ban `org.apache.commons.lang3.Strings`

---
 dev/checkstyle.xml                                             | 1 +
 .../hive/service/auth/LdapAuthenticationProviderImpl.java      | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dev/checkstyle.xml b/dev/checkstyle.xml
index 353a8e4b8050..34082a9aed05 100644
--- a/dev/checkstyle.xml
+++ b/dev/checkstyle.xml
@@ -185,6 +185,7 @@
             <property name="illegalPkgs" value="org.apache.commons.lang" />
             <property name="illegalPkgs" value="org.apache.commons.lang3.tuple" />
             <property name="illegalClasses" value="org.apache.commons.lang3.JavaVersion" />
+            <property name="illegalClasses" value="org.apache.commons.lang3.Strings" />
             <property name="illegalClasses" value="org.apache.hadoop.io.IOUtils" />
             <property name="illegalClasses" value="com.google.common.base.Strings" />
         </module>
diff --git a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java
index 18accf581277..ecf32dd13c79 100644
--- a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java
+++ b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java
@@ -26,7 +26,6 @@
 import javax.naming.directory.InitialDirContext;
 import javax.security.sasl.AuthenticationException;
 
-import org.apache.commons.lang3.Strings;
 import org.apache.hadoop.hive.conf.HiveConf;
 import org.apache.hive.service.ServiceUtils;
 
@@ -72,7 +71,7 @@ public void Authenticate(String user, String password) throws AuthenticationExce
     } else {
       String[] patterns = userDNPattern.split(":");
       for (String pattern : patterns) {
-        if (Strings.CS.contains(pattern, ",") && Strings.CS.contains(pattern, "=")) {
+        if (pattern.contains(",") && pattern.contains("=")) {
           candidatePrincipals.add(pattern.replaceAll("%s", user));
         }
       }