[SPARK-54394][CORE] Move isJavaVersionAtMost17 and isJavaVersionAtLeast21 from core to common/utils
#53108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Merged into master. Thanks @sarutak |
Member
|
+1, LGTM, too. Thank you! |
Member
Author
|
Thank you @LuciferYang and @dongjoon-hyun ! |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…Least21` from `core` to `common/utils` ### What changes were proposed in this pull request? This PR proposes to move `isJavaVersionAtMost17` and `isJavaVersionAtLeast21` from `Utils.scala` in `core` to `SparkSystemUtils.scala` in `common/utils` ### Why are the changes needed? To allow components which don't depend on `core` (like components under `common/utils`) use these methods. These utility methods can be commonly used like `javeVersion` in `SparkSystemUtils.scala`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#53108 from sarutak/move-java-version. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to move
isJavaVersionAtMost17andisJavaVersionAtLeast21fromUtils.scalaincoretoSparkSystemUtils.scalaincommon/utilsWhy are the changes needed?
To allow components which don't depend on
core(like components undercommon/utils) use these methods. These utility methods can be commonly used likejaveVersioninSparkSystemUtils.scala.Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
No.