From 2e1bdb277b1ce2877acc2198812f96b55db9eb10 Mon Sep 17 00:00:00 2001 From: Ubuntu Date: Thu, 20 Nov 2025 19:09:39 +0000 Subject: [PATCH 1/2] initial commit --- .../spark/sql/execution/streaming/state/StateStoreSuite.scala | 2 -- 1 file changed, 2 deletions(-) diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala index 492ea1a06f9c..2d8357d699da 100644 --- a/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala +++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala @@ -2736,7 +2736,6 @@ abstract class StateStoreSuiteBase[ProviderClass <: StateStoreProvider] } test("SPARK-54063: forceSnapshot metric populated when shouldForceSnapshotOnCommit is true") { - withTempDir { dir => tryWithProviderResource(newStoreProvider()) { provider => val store = provider.getStore(0, forceSnapshotOnCommit = true) put(store, "a", 0, 1) @@ -2748,7 +2747,6 @@ abstract class StateStoreSuiteBase[ProviderClass <: StateStoreProvider] } assert(metricPair.isDefined) assert(metricPair.get._2 == 1L, s"forceSnapshot should be 1 but was ${metricPair.get._2}") - } } } From 0ca91a66f8bc3348263b8478741c67a4818a7d5c Mon Sep 17 00:00:00 2001 From: Ubuntu Date: Thu, 20 Nov 2025 19:21:37 +0000 Subject: [PATCH 2/2] change indentation --- .../streaming/state/StateStoreSuite.scala | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala index 2d8357d699da..f16aa013c43c 100644 --- a/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala +++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala @@ -2736,17 +2736,17 @@ abstract class StateStoreSuiteBase[ProviderClass <: StateStoreProvider] } test("SPARK-54063: forceSnapshot metric populated when shouldForceSnapshotOnCommit is true") { - tryWithProviderResource(newStoreProvider()) { provider => - val store = provider.getStore(0, forceSnapshotOnCommit = true) - put(store, "a", 0, 1) - store.commit() - // Verify that a snapshot file was created for version 1 - val metricPair = store.metrics.customMetrics.find { case (metric, _) => - metric.name.contains("rocksdbForceSnapshotCount") || - metric.name.contains("forceSnapshotCount") - } - assert(metricPair.isDefined) - assert(metricPair.get._2 == 1L, s"forceSnapshot should be 1 but was ${metricPair.get._2}") + tryWithProviderResource(newStoreProvider()) { provider => + val store = provider.getStore(0, forceSnapshotOnCommit = true) + put(store, "a", 0, 1) + store.commit() + // Verify that a snapshot file was created for version 1 + val metricPair = store.metrics.customMetrics.find { case (metric, _) => + metric.name.contains("rocksdbForceSnapshotCount") || + metric.name.contains("forceSnapshotCount") + } + assert(metricPair.isDefined) + assert(metricPair.get._2 == 1L, s"forceSnapshot should be 1 but was ${metricPair.get._2}") } }