[SPARK-54523][SQL] Fix default resolution during variant pushdown #53224
+73
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@harshmotw-db let's create a new JIRA ticket for this. |
cloud-fan
approved these changes
Nov 26, 2025
harshmotw-db
changed the title
Contributor
Author
|
@cloud-fan I have created two new Jiras |
cloud-fan
changed the title
cloud-fan
reviewed
Nov 26, 2025
sql/core/src/test/scala/org/apache/spark/sql/VariantSuite.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Nov 26, 2025
Member
There was a problem hiding this comment.
+1, LGTM (if CI passes). Thank you.
To be clear, I removed the following clauses from the PR title and description because we didn't make a decision for the flag, @harshmotw-db and @cloud-fan .
prepare test suites for default enablement of shredding and variant logical type annotationFor default enablement of variant logical type annotation and shredding.
Contributor
|
thanks, merging to master/4.1! |
cloud-fan
added a commit
that referenced
this pull request
Nov 26, 2025
### What changes were proposed in this pull request? [This PR](#53164) enables shredding and variant logical type annotation configs by default. However, some test suites assume the old behavior. This PR fixes those tests to also work with the new default configs. This PR also fixes a bug we discovered in the previous PR where variant default resolution would fail when pushVariantIntoScan was enabled. ### Why are the changes needed? To fix the bug. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53224 from harshmotw-db/harshmotw-db/shredding_fixes. Lead-authored-by: Harsh Motwani <harsh.motwani@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit d36bd62) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enables shredding and variant logical type annotation configs by default. However, some test suites assume the old behavior. This PR fixes those tests to also work with the new default configs.
This PR also fixes a bug we discovered in the previous PR where variant default resolution would fail when pushVariantIntoScan was enabled.
Why are the changes needed?
To fix the bug.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.