[SPARK-56557][SQL][TESTS] Use abstract SparkSession in SparkPlanTest#55443
Closed
zhengruifeng wants to merge 1 commit into
Closed
[SPARK-56557][SQL][TESTS] Use abstract SparkSession in SparkPlanTest#55443zhengruifeng wants to merge 1 commit into
zhengruifeng wants to merge 1 commit into
Conversation
Remove the classic SparkSession override from SparkPlanTest, letting it inherit the abstract SparkSession from SparkSessionProvider. Existing ClassicConversions import handles conversions to classic types where needed internally. Co-authored-by: Isaac
HyukjinKwon
approved these changes
Apr 21, 2026
Contributor
Author
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the classic
SparkSessionoverride fromSparkPlanTest, letting it inherit the abstractSparkSessionfromSparkSessionProvider. Also remove the now-unusedclassicimport.The existing
import org.apache.spark.sql.classic.ClassicConversions._handles implicit conversions to classic types where needed internally (e.g., when passingspark.sparkSessiontonew QueryExecution(...)which takes a classicSparkSession).Why are the changes needed?
SparkPlanTestcurrently requires aclassic.SparkSession, which tightly couples it to the classic implementation. Widening the type to the abstractSparkSessionfollows the same pattern as SPARK-56483 (SQLTestUtilsBase) — makes the test infrastructure more uniform and reduces direct references to the classic package in test utilities.12 test suites extend
SparkPlanTestand continue to work unchanged:SortSuite,ExchangeSuite,BroadcastExchangeSuite,ReuseExchangeAndSubquerySuite,TakeOrderedAndProjectSuite,BaseScriptTransformationSuite,InnerJoinSuite,OuterJoinSuite,ExistenceJoinSuite,SingleJoinSuite,BatchEvalPythonExecSuite,ExtractPythonUDFsSuite.Does this PR introduce any user-facing change?
No.
SparkPlanTestisprivate[sql].How was this patch tested?
CI compilation across all modules.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-6)