[SPARK-56864][INFRA][PYTHON] Consolidate python-ps-minimum image into python-minimum#55872
Closed
zhengruifeng wants to merge 2 commits into
Closed
[SPARK-56864][INFRA][PYTHON] Consolidate python-ps-minimum image into python-minimum#55872zhengruifeng wants to merge 2 commits into
zhengruifeng wants to merge 2 commits into
Conversation
zhengruifeng
changed the title
dongjoon-hyun
approved these changes
May 14, 2026
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
cc @peter-toth
HyukjinKwon
approved these changes
May 14, 2026
peter-toth
approved these changes
May 15, 2026
Generated-by: Claude Code (model: claude-opus-4-7)
Generated-by: Claude Code (model: claude-opus-4-7)
zhengruifeng
force-pushed
the
remove-python-ps-minimum
branch
from
75e22e7 to
682212e
Compare
Contributor
Author
|
thanks all, merged to master. |
This was referenced May 18, 2026
Closed
zhengruifeng
added a commit
that referenced
this pull request
May 18, 2026
… into python-minimum ### What changes were proposed in this pull request? Backport of #55872 to branch-4.2. This PR consolidates the `python-ps-minimum` Docker image and its CI workflow into the existing `python-minimum` image, eliminating a near-duplicate. Specifically: - Deletes `dev/spark-test-image/python-ps-minimum/Dockerfile`. - Deletes `.github/workflows/build_python_ps_minimum.yml`. - Adds `"pyspark-pandas": "true"` to `.github/workflows/build_python_minimum.yml` so Pandas API on Spark minimum-deps coverage is preserved. - Drops the `python-ps-minimum` entries from `.github/workflows/build_infra_images_cache.yml` (the `paths` trigger and the build/push step). - Removes the `build_python_ps_minimum.yml` badge from `README.md`. ### Why are the changes needed? To save CI resources. The two Dockerfiles were nearly identical. The only functional differences were in `BASIC_PIP_PKGS`: | Package | python-minimum | python-ps-minimum | |---|---|---| | `numpy` | pinned `==1.22.4` | unpinned | | `scikit-learn` | included | omitted | Everything else (base image, apt packages, Python version, venv setup, `CONNECT_PIP_PKGS`) was the same. Maintaining both images doubles the image build/cache cost and runs a duplicate scheduled workflow without commensurate test value. Reusing `python-minimum` (which has the stricter pin and a superset of packages) for the Pandas API on Spark minimum-deps job keeps coverage while halving the image footprint and the associated CI runtime. ### Does this PR introduce _any_ user-facing change? No. CI-only change. ### How was this patch tested? Existing CI. The merged `build_python_minimum.yml` now runs both `pyspark` and `pyspark-pandas` jobs against the `python-minimum` image. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (model: claude-opus-4-7) Closes #55945 from zhengruifeng/backport-spark-56864-to-4.2. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
zhengruifeng
added a commit
that referenced
this pull request
May 18, 2026
… into python-minimum ### What changes were proposed in this pull request? Backport of #55872 to branch-4.x. This PR consolidates the `python-ps-minimum` Docker image and its CI workflow into the existing `python-minimum` image, eliminating a near-duplicate. Specifically: - Deletes `dev/spark-test-image/python-ps-minimum/Dockerfile`. - Deletes `.github/workflows/build_python_ps_minimum.yml`. - Adds `"pyspark-pandas": "true"` to `.github/workflows/build_python_minimum.yml` so Pandas API on Spark minimum-deps coverage is preserved. - Drops the `python-ps-minimum` entries from `.github/workflows/build_infra_images_cache.yml` (the `paths` trigger and the build/push step). - Removes the `build_python_ps_minimum.yml` badge from `README.md`. ### Why are the changes needed? To save CI resources. The two Dockerfiles were nearly identical. The only functional differences were in `BASIC_PIP_PKGS`: | Package | python-minimum | python-ps-minimum | |---|---|---| | `numpy` | pinned `==1.22.4` | unpinned | | `scikit-learn` | included | omitted | Everything else (base image, apt packages, Python version, venv setup, `CONNECT_PIP_PKGS`) was the same. Maintaining both images doubles the image build/cache cost and runs a duplicate scheduled workflow without commensurate test value. Reusing `python-minimum` (which has the stricter pin and a superset of packages) for the Pandas API on Spark minimum-deps job keeps coverage while halving the image footprint and the associated CI runtime. ### Does this PR introduce _any_ user-facing change? No. CI-only change. ### How was this patch tested? Existing CI. The merged `build_python_minimum.yml` now runs both `pyspark` and `pyspark-pandas` jobs against the `python-minimum` image. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (model: claude-opus-4-7) Closes #55944 from zhengruifeng/backport-spark-56864-to-4.x. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR consolidates the
python-ps-minimumDocker image and its CI workflow into the existingpython-minimumimage, eliminating a near-duplicate.Specifically:
dev/spark-test-image/python-minimum/Dockerfileto cover both PySpark and Pandas API on Spark.dev/spark-test-image/python-ps-minimum/Dockerfile..github/workflows/build_python_ps_minimum.yml."pyspark-pandas": "true"to.github/workflows/build_python_minimum.ymlso Pandas API on Spark minimum-deps coverage is preserved.python-ps-minimumentries from.github/workflows/build_infra_images_cache.yml(thepathstrigger and the build/push step).build_python_ps_minimum.ymlbadge fromREADME.md.Why are the changes needed?
To save CI resources. The two Dockerfiles were nearly identical. The only functional differences were in
BASIC_PIP_PKGS:numpy==1.22.4scikit-learnEverything else (base image, apt packages, Python version, venv setup,
CONNECT_PIP_PKGS) was the same. Maintaining both images doubles the image build/cache cost and runs a duplicate scheduled workflow without commensurate test value. Reusingpython-minimum(which has the stricter pin and a superset of packages) for the Pandas API on Spark minimum-deps job keeps coverage while halving the image footprint and the associated CI runtime.Does this PR introduce any user-facing change?
No. CI-only change.
How was this patch tested?
Existing CI. The merged
build_python_minimum.ymlnow runs bothpysparkandpyspark-pandasjobs against thepython-minimumimage.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (model: claude-opus-4-7)