Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove broken/unused Connection.getChunkFIFO method. #69

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

kayousterhout commented Mar 4, 2014

This method appears to be broken -- since it never removes
anything from messages, and it adds new messages to it,
the while loop is an infinite loop. The method also does not appear
to have ever been used since the code was added in 2012, so
this commit removes it.

cc @mateiz who originally added this method in case there's a reason it should be here! (63051dd)

Kay Ousterhout Remove broken/unused Connection.getChunkFIFO method.
This method appears to be broken -- since it never removes
anything from messages, and it adds new messages to it,
the while loop is an infinite loop.  The method also does not appear
to have ever been used since the code was added in 2012, so
this commit removes it.
053bc59

Merged build triggered.

Merged build started.

Contributor

mateiz commented Mar 4, 2014

@tdas should take a look at this actually, I think it was his code. But yes there's no reason to keep FIFO.

Merged build finished.

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12974/

Contributor

mateiz commented Mar 4, 2014

I've merged this, thanks.

@asfgit asfgit closed this in b14ede7 Mar 4, 2014

@jhartlaub jhartlaub referenced this pull request in jhartlaub/spark May 27, 2014

@mateiz @rxin mateiz + rxin Merge pull request #69 from KarthikTunga/master
Fix for issue SPARK-627. Implementing --config argument in the scripts.

This code fix is for issue SPARK-627. I added code to consider --config arguments in the scripts. In case the  <conf-dir> is not a directory the scripts exit. I removed the --hosts argument. It can be achieved by giving a different config directory. Let me know if an explicit --hosts argument is required.

(cherry picked from commit fc26e5b)
Signed-off-by: Reynold Xin <rxin@apache.org>
df21ac8

@CrazyJvm CrazyJvm added a commit to CrazyJvm/spark that referenced this pull request Jun 1, 2014

@CrazyJvm Kay Ousterhout + CrazyJvm Remove broken/unused Connection.getChunkFIFO method.
This method appears to be broken -- since it never removes
anything from messages, and it adds new messages to it,
the while loop is an infinite loop.  The method also does not appear
to have ever been used since the code was added in 2012, so
this commit removes it.

cc @mateiz who originally added this method in case there's a reason it should be here! (apache@63051dd)

Author: Kay Ousterhout <kayousterhout@gmail.com>

Closes #69 from kayousterhout/remove_get_fifo and squashes the following commits:

053bc59 [Kay Ousterhout] Remove broken/unused Connection.getChunkFIFO method.
573d30f

@JasonMWhite JasonMWhite pushed a commit to JasonMWhite/spark that referenced this pull request Dec 2, 2015

@airhorns airhorns Merge pull request #69 from Shopify/s3-upload
Upload a tar of our spark to s3
99e6388

@ash211 ash211 added a commit to ash211/spark that referenced this pull request Feb 2, 2017

@mccheah @ash211 mccheah + ash211 Retry the submit-application request to multiple nodes (#69)
* Retry the submit-application request to multiple nodes.

* Fix doc style comment

* Check node unschedulable, log retry failures
0c3ff11

@lins05 lins05 pushed a commit to lins05/spark that referenced this pull request Apr 23, 2017

@mccheah @ash211 mccheah + ash211 Retry the submit-application request to multiple nodes (#69)
* Retry the submit-application request to multiple nodes.

* Fix doc style comment

* Check node unschedulable, log retry failures
6ee3be5

@erikerlandson erikerlandson pushed a commit to erikerlandson/spark that referenced this pull request Jul 28, 2017

@mccheah @foxish mccheah + foxish Retry the submit-application request to multiple nodes (#69)
* Retry the submit-application request to multiple nodes.

* Fix doc style comment

* Check node unschedulable, log retry failures
261a624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment