New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-6602][Core]Remove unnecessary synchronized #7141

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@zsxwing
Member

zsxwing commented Jul 1, 2015

A follow-up pr to address #5392 (comment)

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 1, 2015

Merged build triggered.

AmplabJenkins commented Jul 1, 2015

Merged build triggered.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 1, 2015

Merged build started.

AmplabJenkins commented Jul 1, 2015

Merged build started.

@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA commented Jul 1, 2015

Test build #36222 has started for PR 7141 at commit fcf7b50.

@rxin

This comment has been minimized.

Show comment
Hide comment
@rxin

rxin Jul 1, 2015

Contributor

lgtm

Contributor

rxin commented Jul 1, 2015

lgtm

@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Jul 1, 2015

Test build #36222 has finished for PR 7141 at commit fcf7b50.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Heartbeat(workerId: String, worker: RpcEndpointRef) extends DeployMessage
    • case class RegisteredWorker(master: RpcEndpointRef, masterWebUiUrl: String) extends DeployMessage
    • case class RegisterApplication(appDescription: ApplicationDescription, driver: RpcEndpointRef)
    • case class RegisteredApplication(appId: String, master: RpcEndpointRef) extends DeployMessage
    • case class SubmitDriverResponse(
    • case class KillDriverResponse(
    • case class MasterChanged(master: RpcEndpointRef, masterWebUiUrl: String)

SparkQA commented Jul 1, 2015

Test build #36222 has finished for PR 7141 at commit fcf7b50.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Heartbeat(workerId: String, worker: RpcEndpointRef) extends DeployMessage
    • case class RegisteredWorker(master: RpcEndpointRef, masterWebUiUrl: String) extends DeployMessage
    • case class RegisterApplication(appDescription: ApplicationDescription, driver: RpcEndpointRef)
    • case class RegisteredApplication(appId: String, master: RpcEndpointRef) extends DeployMessage
    • case class SubmitDriverResponse(
    • case class KillDriverResponse(
    • case class MasterChanged(master: RpcEndpointRef, masterWebUiUrl: String)
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 1, 2015

Merged build finished. Test PASSed.

AmplabJenkins commented Jul 1, 2015

Merged build finished. Test PASSed.

@asfgit asfgit closed this in 64c1461 Jul 1, 2015

@zsxwing zsxwing deleted the zsxwing:pr5392-follow-up branch Jul 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment