New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-9198] [mllib] [python] Fixed typo in pyspark sparsevector doc tests #7541

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@jkbradley
Member

jkbradley commented Jul 20, 2015

Several places in the PySpark SparseVector docs have one defined as:

SparseVector(4, [2, 4], [1.0, 2.0])

The index 4 goes out of bounds (but this is not checked).

CC: @mengxr

@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Jul 20, 2015

Test build #37849 has finished for PR 7541 at commit e2dcb23.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait Nondeterministic
    • abstract class RDG extends LeafExpression with Nondeterministic
    • case class Rand(seed: Long) extends RDG
    • case class Randn(seed: Long) extends RDG

SparkQA commented Jul 20, 2015

Test build #37849 has finished for PR 7541 at commit e2dcb23.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait Nondeterministic
    • abstract class RDG extends LeafExpression with Nondeterministic
    • case class Rand(seed: Long) extends RDG
    • case class Randn(seed: Long) extends RDG
@SparkQA

This comment has been minimized.

Show comment
Hide comment
@SparkQA

SparkQA Jul 20, 2015

Test build #37850 has finished for PR 7541 at commit c806a65.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait Nondeterministic
    • abstract class RDG extends LeafExpression with Nondeterministic
    • case class Rand(seed: Long) extends RDG
    • case class Randn(seed: Long) extends RDG

SparkQA commented Jul 20, 2015

Test build #37850 has finished for PR 7541 at commit c806a65.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait Nondeterministic
    • abstract class RDG extends LeafExpression with Nondeterministic
    • case class Rand(seed: Long) extends RDG
    • case class Randn(seed: Long) extends RDG
@feynmanliang

This comment has been minimized.

Show comment
Hide comment
@feynmanliang

feynmanliang Jul 20, 2015

Contributor

LGTM

Contributor

feynmanliang commented Jul 20, 2015

LGTM

asfgit pushed a commit that referenced this pull request Jul 20, 2015

[SPARK-9198] [MLLIB] [PYTHON] Fixed typo in pyspark sparsevector doc …
…tests

Several places in the PySpark SparseVector docs have one defined as:
```
SparseVector(4, [2, 4], [1.0, 2.0])
```
The index 4 goes out of bounds (but this is not checked).

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #7541 from jkbradley/sparsevec-doc-typo-fix and squashes the following commits:

c806a65 [Joseph K. Bradley] fixed doc test
e2dcb23 [Joseph K. Bradley] Fixed typo in pyspark sparsevector doc tests

(cherry picked from commit a5d0581)
Signed-off-by: Xiangrui Meng <meng@databricks.com>

asfgit pushed a commit that referenced this pull request Jul 20, 2015

[SPARK-9198] [MLLIB] [PYTHON] Fixed typo in pyspark sparsevector doc …
…tests

Several places in the PySpark SparseVector docs have one defined as:
```
SparseVector(4, [2, 4], [1.0, 2.0])
```
The index 4 goes out of bounds (but this is not checked).

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #7541 from jkbradley/sparsevec-doc-typo-fix and squashes the following commits:

c806a65 [Joseph K. Bradley] fixed doc test
e2dcb23 [Joseph K. Bradley] Fixed typo in pyspark sparsevector doc tests

(cherry picked from commit a5d0581)
Signed-off-by: Xiangrui Meng <meng@databricks.com>

asfgit pushed a commit that referenced this pull request Jul 20, 2015

[SPARK-9198] [MLLIB] [PYTHON] Fixed typo in pyspark sparsevector doc …
…tests

Several places in the PySpark SparseVector docs have one defined as:
```
SparseVector(4, [2, 4], [1.0, 2.0])
```
The index 4 goes out of bounds (but this is not checked).

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #7541 from jkbradley/sparsevec-doc-typo-fix and squashes the following commits:

c806a65 [Joseph K. Bradley] fixed doc test
e2dcb23 [Joseph K. Bradley] Fixed typo in pyspark sparsevector doc tests

(cherry picked from commit a5d0581)
Signed-off-by: Xiangrui Meng <meng@databricks.com>

@asfgit asfgit closed this in a5d0581 Jul 20, 2015

asfgit pushed a commit that referenced this pull request Jul 20, 2015

[SPARK-9198] [MLLIB] [PYTHON] Fixed typo in pyspark sparsevector doc …
…tests

Several places in the PySpark SparseVector docs have one defined as:
```
SparseVector(4, [2, 4], [1.0, 2.0])
```
The index 4 goes out of bounds (but this is not checked).

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #7541 from jkbradley/sparsevec-doc-typo-fix and squashes the following commits:

c806a65 [Joseph K. Bradley] fixed doc test
e2dcb23 [Joseph K. Bradley] Fixed typo in pyspark sparsevector doc tests

(cherry picked from commit a5d0581)
Signed-off-by: Xiangrui Meng <meng@databricks.com>

asfgit pushed a commit that referenced this pull request Jul 20, 2015

[SPARK-9198] [MLLIB] [PYTHON] Fixed typo in pyspark sparsevector doc …
…tests

Several places in the PySpark SparseVector docs have one defined as:
```
SparseVector(4, [2, 4], [1.0, 2.0])
```
The index 4 goes out of bounds (but this is not checked).

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #7541 from jkbradley/sparsevec-doc-typo-fix and squashes the following commits:

c806a65 [Joseph K. Bradley] fixed doc test
e2dcb23 [Joseph K. Bradley] Fixed typo in pyspark sparsevector doc tests

(cherry picked from commit a5d0581)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr

This comment has been minimized.

Show comment
Hide comment
@mengxr

mengxr Jul 20, 2015

Contributor

Merged into master and all branches since 1.0. Thanks!

Contributor

mengxr commented Jul 20, 2015

Merged into master and all branches since 1.0. Thanks!

@jkbradley jkbradley deleted the jkbradley:sparsevec-doc-typo-fix branch Jul 21, 2015

dennishuo added a commit to dennishuo/spark that referenced this pull request Aug 7, 2015

[SPARK-9198] [MLLIB] [PYTHON] Fixed typo in pyspark sparsevector doc …
…tests

Several places in the PySpark SparseVector docs have one defined as:
```
SparseVector(4, [2, 4], [1.0, 2.0])
```
The index 4 goes out of bounds (but this is not checked).

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #7541 from jkbradley/sparsevec-doc-typo-fix and squashes the following commits:

c806a65 [Joseph K. Bradley] fixed doc test
e2dcb23 [Joseph K. Bradley] Fixed typo in pyspark sparsevector doc tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment