Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-10934][SQL] handle hashCode of unsafe array correctly #8987

Closed
wants to merge 1 commit into from

Conversation

cloud-fan
Copy link
Contributor

Murmur3_x86_32.hashUnsafeWords only accepts word-aligned bytes, but unsafe array is not.

@cloud-fan
Copy link
Contributor Author

cc @davies

@SparkQA
Copy link

SparkQA commented Oct 5, 2015

Test build #43255 has finished for PR 8987 at commit 99c62b6.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • final class ChiSqSelector(override val uid: String)
    • final class QuantileDiscretizer(override val uid: String)
    • public class BufferHolder
    • public class UnsafeArrayWriter
    • public class UnsafeRowWriter
    • case class HyperLogLogPlusPlus(child: Expression, relativeSD: Double = 0.05)
    • case class JsonTuple(children: Seq[Expression])
    • abstract class UnaryMathExpression(val f: Double => Double, name: String)
    • case class Ceil(child: Expression) extends UnaryMathExpression(math.ceil, "CEIL")
    • case class Floor(child: Expression) extends UnaryMathExpression(math.floor, "FLOOR")
    • case class LogicalRelation(
    • public final class ByteArray

@cloud-fan
Copy link
Contributor Author

retest this please.

@SparkQA
Copy link

SparkQA commented Oct 6, 2015

Test build #1844 has finished for PR 8987 at commit 99c62b6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class BufferHolder
    • public class UnsafeArrayWriter
    • public class UnsafeRowWriter
    • case class LogicalRelation(

@asfgit asfgit closed this in a609eb2 Oct 6, 2015
asfgit pushed a commit that referenced this pull request Oct 6, 2015
`Murmur3_x86_32.hashUnsafeWords` only accepts word-aligned bytes, but unsafe array is not.

Author: Wenchen Fan <cloud0fan@163.com>

Closes #8987 from cloud-fan/hash.
@davies
Copy link
Contributor

davies commented Oct 6, 2015

Merged into master and branch-1.5, thanks!

@SparkQA
Copy link

SparkQA commented Oct 6, 2015

Test build #43256 has finished for PR 8987 at commit 99c62b6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class BufferHolder
    • public class UnsafeArrayWriter
    • public class UnsafeRowWriter

@cloud-fan cloud-fan deleted the hash branch October 6, 2015 00:45
@SparkQA
Copy link

SparkQA commented Oct 6, 2015

Test build #43254 has finished for PR 8987 at commit 540b3c0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class BufferHolder
    • public class UnsafeArrayWriter
    • public class UnsafeRowWriter

mccheah pushed a commit to palantir/spark that referenced this pull request Oct 21, 2015
`Murmur3_x86_32.hashUnsafeWords` only accepts word-aligned bytes, but unsafe array is not.

Author: Wenchen Fan <cloud0fan@163.com>

Closes apache#8987 from cloud-fan/hash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants