Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-1888: add description for shell command #1472

Merged
merged 1 commit into from Jun 24, 2016
Merged

Conversation

@vesense
Copy link
Member

vesense commented Jun 8, 2016

This can be cherry-picked to 1.x-branch.

@@ -485,6 +485,11 @@ def kill_workers(*args):
extrajars=[USER_CONF_DIR, os.path.join(STORM_DIR, "bin")])

def shell(resourcesdir, command, *args):
"""Syntax: [storm shell resourcesdir command args]
Makes constructing jar and uploading to nimbus for using non JVM languages

This comment has been minimized.

Copy link
@HeartSaVioR

HeartSaVioR Jun 22, 2016

Contributor

I feel this line misses behavior "executing command".

I'd like to have this line changed like
Archives resources to jar and uploads jar to Nimbus, and executes following arguments on "local". Useful for non JVM languages.

This comment has been minimized.

Copy link
@vesense

vesense Jun 22, 2016

Author Member

Thanks @HeartSaVioR This is even better. Updated.

@vesense vesense force-pushed the vesense:STORM-1888 branch from 7979daa to dbec495 Jun 22, 2016
@vesense

This comment has been minimized.

Copy link
Member Author

vesense commented Jun 22, 2016

@HeartSaVioR Updated and rebased.

@HeartSaVioR

This comment has been minimized.

Copy link
Contributor

HeartSaVioR commented Jun 24, 2016

+1 Thanks @vesense for following up.

@asfgit asfgit merged commit dbec495 into apache:master Jun 24, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.