New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storm-2104 1.0.x #1980

Merged
merged 3 commits into from Mar 9, 2017

Conversation

Projects
None yet
3 participants
@srdo
Contributor

srdo commented Feb 28, 2017

Putting #1818 on 1.0.x as well since @qiozas asked about it here #1696

Only change from 1.x version is that KafkaSpout.emitTupleIfNotEmitted returns void instead of boolean here.

@@ -164,15 +164,15 @@ public Builder(Map<String, Object> kafkaProps, KafkaSpoutStreams kafkaSpoutStrea
/**
* Specifying this key deserializer overrides the property key.deserializer
*/
- public Builder<K,V> setKeyDeserializer(Deserializer<K> keyDeserializer) {
+ public Builder<K,V> setKeyDeserializer(SerializableDeserializer<K> keyDeserializer) {

This comment has been minimized.

@HeartSaVioR

HeartSaVioR Mar 8, 2017

Contributor

I'm not 100% sure it keeps binary compatibility. Serializable doesn't have methods so it might work, but just not sure.
Once who makes me clear that this is also safe for binary compatibility, I'll give +1.

(We decided to break backward compatibility for 1.x but not 1.0.x.)

@HeartSaVioR

HeartSaVioR Mar 8, 2017

Contributor

I'm not 100% sure it keeps binary compatibility. Serializable doesn't have methods so it might work, but just not sure.
Once who makes me clear that this is also safe for binary compatibility, I'll give +1.

(We decided to break backward compatibility for 1.x but not 1.0.x.)

This comment has been minimized.

@srdo

srdo Mar 8, 2017

Contributor

It doesn't. I'll revert this part.

@srdo

srdo Mar 8, 2017

Contributor

It doesn't. I'll revert this part.

@HeartSaVioR

This comment has been minimized.

Show comment
Hide comment
@HeartSaVioR

HeartSaVioR Mar 8, 2017

Contributor

Thanks for the quick fix. +1

Contributor

HeartSaVioR commented Mar 8, 2017

Thanks for the quick fix. +1

@asfgit asfgit merged commit dc78c16 into apache:1.0.x-branch Mar 9, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment