New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventhub2 #1998

Closed

rban1 wants to merge 6 commits into apache:master from rban1:eventhub2

rban1 commented Mar 13, 2017

latest changes

Ranjan Banerjee and others added 3 commits

February 21, 2017 13:51


          Implementing new eventhub driver

098272d


          eventhub latest changes

2a603b3


          Update pom.xml

54cd6ff

harshach reviewed

View reviewed changes

external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java

@@ @@ -41,7 +42,8 @@ @@
               			.getLogger(EventHubBolt.class);
               	protected OutputCollector collector;
-              	protected EventHubSender sender;
+              	protected PartitionSender sender=null;

Contributor

harshach Mar 18, 2017

Don't need to assign null

external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java

@@ @@ -84,11 +85,47 @@ public void prepare(Map config, TopologyContext context, @@
               	@Override
               	public void execute(Tuple tuple) {
               		try {
-              			sender.send(boltConfig.getEventDataFormat().serialize(tuple));
+              			EventData sendEvent = new EventData(boltConfig.getEventDataFormat().serialize(tuple));
+              			if(boltConfig.getPartitionMode() && sender!=null)

Contributor

harshach Mar 18, 2017

can you please add braces around if conditions. This goes to all of the code.

external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java

+              	public void cleanup() {
+              		if(sender != null) {
+              			try {
+              				sender.close().whenComplete((voidargs,error)->{

Contributor

harshach Mar 18, 2017

FYI, 1.x-branch still is on JDK 1.7 make sure you open another PR for 1.x-branch with JDK7 changes.

...nal/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java

+                            offset,
+                            false,
+);
+                  }catch (Exception e){

Contributor

harshach Mar 18, 2017

spaces around the braces

...nal/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java

+                  try {
+                    ehClient = EventHubClient.createFromConnectionStringSync(connectionString);
+                    receiver = ehClient.createEpochReceiverSync(
+                            consumerGroupName,

Contributor

harshach Mar 18, 2017

indentation here

...nal/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java

+                            logger.error("Exception during receiver close phase"+error.toString());
+                          }
+                          ehClient.closeSync();
+                        }catch (Exception e){

Contributor

harshach Mar 18, 2017

same here

...nal/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java

+                          logger.error("Exception during ehclient close phase"+e.toString());
+                        }
+                      }).get();
+                    }catch (InterruptedException e){

Contributor

harshach Mar 18, 2017

same here

...nal/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java

+                      }).get();
+                    }catch (InterruptedException e){
+                      logger.error("Exception occured during close phase"+e.toString());
+                    }catch (ExecutionException e){

Contributor

harshach Mar 18, 2017

same here

...nal/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java

+                  /*Get one message at a time for backward compatibility behaviour*/
+                  try {
+                    receivedEvents = receiver.receiveSync(1);
+                  }catch (ServiceBusException e){

Contributor

harshach Mar 18, 2017

same here

external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/PartitionManager.java

@@ @@ -74,8 +74,8 @@ public void ack(String offset) { @@
                 @Override
                 public void fail(String offset) {
                   logger.warn("fail on " + offset);

Contributor

harshach Mar 18, 2017

this might trigger lot of log writing if the spout starts failing. May be good idea to make it debug

Ranjan Banerjee added 3 commits

March 22, 2017 09:18


          new eventhub api realted changes

cd733e1


          Merge branch 'eventhub2' of https://github.com/rban1/storm into event…

e85e37d

…hub2


          api changes in eventhub

4b034fe

Contributor

harshach commented Mar 27, 2017

@rban1 there are still some unaddressed comments and also merge conflicts. Make sure you squashed your commits for the PR as well.

d2r pushed a commit to d2r/storm that referenced this pull request


          Closes Pull Requests unchanged in 2018

fcda81c

We are closing stale Pull Requests to make the list more manageable.

Please re-open any Pull Request that has been closed in error.

Closes apache#608
Closes apache#639
Closes apache#640
Closes apache#648
Closes apache#662
Closes apache#668
Closes apache#692
Closes apache#705
Closes apache#724
Closes apache#728
Closes apache#730
Closes apache#753
Closes apache#803
Closes apache#854
Closes apache#922
Closes apache#986
Closes apache#992
Closes apache#1019
Closes apache#1040
Closes apache#1041
Closes apache#1043
Closes apache#1046
Closes apache#1051
Closes apache#1078
Closes apache#1146
Closes apache#1164
Closes apache#1165
Closes apache#1178
Closes apache#1213
Closes apache#1225
Closes apache#1258
Closes apache#1259
Closes apache#1268
Closes apache#1272
Closes apache#1277
Closes apache#1278
Closes apache#1288
Closes apache#1296
Closes apache#1328
Closes apache#1342
Closes apache#1353
Closes apache#1370
Closes apache#1376
Closes apache#1391
Closes apache#1395
Closes apache#1399
Closes apache#1406
Closes apache#1410
Closes apache#1422
Closes apache#1427
Closes apache#1443
Closes apache#1462
Closes apache#1468
Closes apache#1483
Closes apache#1506
Closes apache#1509
Closes apache#1515
Closes apache#1520
Closes apache#1521
Closes apache#1525
Closes apache#1527
Closes apache#1544
Closes apache#1550
Closes apache#1566
Closes apache#1569
Closes apache#1570
Closes apache#1575
Closes apache#1580
Closes apache#1584
Closes apache#1591
Closes apache#1600
Closes apache#1611
Closes apache#1613
Closes apache#1639
Closes apache#1703
Closes apache#1711
Closes apache#1719
Closes apache#1737
Closes apache#1760
Closes apache#1767
Closes apache#1768
Closes apache#1785
Closes apache#1799
Closes apache#1822
Closes apache#1824
Closes apache#1844
Closes apache#1874
Closes apache#1918
Closes apache#1928
Closes apache#1937
Closes apache#1942
Closes apache#1951
Closes apache#1957
Closes apache#1963
Closes apache#1964
Closes apache#1965
Closes apache#1967
Closes apache#1968
Closes apache#1971
Closes apache#1985
Closes apache#1986
Closes apache#1998
Closes apache#2031
Closes apache#2032
Closes apache#2071
Closes apache#2076
Closes apache#2108
Closes apache#2119
Closes apache#2128
Closes apache#2142
Closes apache#2174
Closes apache#2206
Closes apache#2297
Closes apache#2322
Closes apache#2332
Closes apache#2341
Closes apache#2377
Closes apache#2414
Closes apache#2469

d2r pushed a commit to d2r/storm that referenced this pull request


          Closes Pull Requests unchanged in 2018

fdb95d0

We are closing stale Pull Requests to make the list more manageable.

Please re-open any Pull Request that has been closed in error.

Closes apache#608
Closes apache#639
Closes apache#640
Closes apache#648
Closes apache#662
Closes apache#668
Closes apache#692
Closes apache#705
Closes apache#724
Closes apache#728
Closes apache#730
Closes apache#753
Closes apache#803
Closes apache#854
Closes apache#922
Closes apache#986
Closes apache#992
Closes apache#1019
Closes apache#1040
Closes apache#1041
Closes apache#1043
Closes apache#1046
Closes apache#1051
Closes apache#1078
Closes apache#1146
Closes apache#1164
Closes apache#1165
Closes apache#1178
Closes apache#1213
Closes apache#1225
Closes apache#1258
Closes apache#1259
Closes apache#1268
Closes apache#1272
Closes apache#1277
Closes apache#1278
Closes apache#1288
Closes apache#1296
Closes apache#1328
Closes apache#1342
Closes apache#1353
Closes apache#1370
Closes apache#1376
Closes apache#1391
Closes apache#1395
Closes apache#1399
Closes apache#1406
Closes apache#1410
Closes apache#1422
Closes apache#1427
Closes apache#1443
Closes apache#1462
Closes apache#1468
Closes apache#1483
Closes apache#1506
Closes apache#1509
Closes apache#1515
Closes apache#1520
Closes apache#1521
Closes apache#1525
Closes apache#1527
Closes apache#1544
Closes apache#1550
Closes apache#1566
Closes apache#1569
Closes apache#1570
Closes apache#1575
Closes apache#1580
Closes apache#1584
Closes apache#1591
Closes apache#1600
Closes apache#1611
Closes apache#1613
Closes apache#1639
Closes apache#1703
Closes apache#1711
Closes apache#1719
Closes apache#1737
Closes apache#1760
Closes apache#1767
Closes apache#1768
Closes apache#1785
Closes apache#1799
Closes apache#1822
Closes apache#1824
Closes apache#1844
Closes apache#1874
Closes apache#1918
Closes apache#1928
Closes apache#1937
Closes apache#1942
Closes apache#1951
Closes apache#1957
Closes apache#1963
Closes apache#1964
Closes apache#1965
Closes apache#1967
Closes apache#1968
Closes apache#1971
Closes apache#1985
Closes apache#1986
Closes apache#1998
Closes apache#2031
Closes apache#2032
Closes apache#2071
Closes apache#2076
Closes apache#2108
Closes apache#2119
Closes apache#2128
Closes apache#2142
Closes apache#2174
Closes apache#2206
Closes apache#2297
Closes apache#2322
Closes apache#2332
Closes apache#2341
Closes apache#2377
Closes apache#2414
Closes apache#2469

d2r mentioned this pull request

STORM-3250: Closes Pull Requests unchanged in 2018 #2880

Merged

asfgit closed this in #2880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment