STORM-2451: windows storm.cmd does not set log4j2 config file correct… #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly by default the dir from the default config is log4j2 and that should be relative to STORM_HOME, however this is check was missing Signed-off-by: alexlehm <alexlehm@gmail.com>
|
I don't have Windows machine but code change looks good to me, so +1 assuming you tested this manually. |
|
yes, i am using the modified start script now (with the 1.1.0 release) |
|
This PR is merged into asf git but asf git seems have some issue which might be related to mirror trigger. I'll try sync up mirror tomorrow. This will be closed automatically after sync up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ly by default
the dir from the default config is log4j2 and that should be relative to STORM_HOME, however this is check was missing
Signed-off-by: alexlehm alexlehm@gmail.com